crypto: ux500 - Fix error return code in hash_hw_final()
authorZhen Lei <thunder.leizhen@huawei.com>
Sat, 8 May 2021 07:00:49 +0000 (15:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:56:03 +0000 (16:56 +0200)
[ Upstream commit b01360384009ab066940b45f34880991ea7ccbfb ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 8a63b1994c50 ("crypto: ux500 - Add driver for HASH hardware")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/ux500/hash/hash_core.c

index 3d407eebb2babc816294e588e5575fac63735d11..1e2daf403032717ff5646ea00eca204a44fb712f 100644 (file)
@@ -1009,6 +1009,7 @@ static int hash_hw_final(struct ahash_request *req)
                        goto out;
                }
        } else if (req->nbytes == 0 && ctx->keylen > 0) {
+               ret = -EPERM;
                dev_err(device_data->dev, "%s: Empty message with keylength > 0, NOT supported\n",
                        __func__);
                goto out;