liquidio: remove set but not used variable 'is25G'
authorYueHaibing <yuehaibing@huawei.com>
Mon, 13 Aug 2018 09:29:36 +0000 (17:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Aug 2018 16:21:05 +0000 (09:21 -0700)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function 'lio_set_link_ksettings':
drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:392:6: warning:
 variable 'is25G' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/liquidio/lio_ethtool.c

index 807ea2c..8e05afd 100644 (file)
@@ -389,18 +389,14 @@ static int lio_set_link_ksettings(struct net_device *netdev,
        struct lio *lio = GET_LIO(netdev);
        struct oct_link_info *linfo;
        struct octeon_device *oct;
-       u32 is25G = 0;
 
        oct = lio->oct_dev;
 
        linfo = &lio->linfo;
 
-       if (oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID ||
-           oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID) {
-               is25G = 1;
-       } else {
+       if (!(oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID ||
+             oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID))
                return -EOPNOTSUPP;
-       }
 
        if (oct->no_speed_setting) {
                dev_err(&oct->pci_dev->dev, "%s: Changing speed is not supported\n",