mkiss: remove redundant check on len being zero
authorColin Ian King <colin.king@canonical.com>
Wed, 27 Sep 2017 21:45:13 +0000 (22:45 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Sep 2017 04:44:28 +0000 (05:44 +0100)
The check on len is redundant as it is always greater than 1,
so just remove it and make the printk less complex.

Detected by CoverityScan, CID#1226729 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hamradio/mkiss.c

index aec6c26..54bf8e6 100644 (file)
@@ -477,7 +477,8 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len)
                                  cmd = 0;
                                }
                                ax->crcauto = (cmd ? 0 : 1);
-                               printk(KERN_INFO "mkiss: %s: crc mode %s %d\n", ax->dev->name, (len) ? "set to" : "is", cmd);
+                               printk(KERN_INFO "mkiss: %s: crc mode set to %d\n",
+                                      ax->dev->name, cmd);
                        }
                        spin_unlock_bh(&ax->buflock);
                        netif_start_queue(dev);