Remind users to use the --use-dynamic command line option to dump dynamic relocations.

	* readelf.c (process_relocs): Tell users if no static relocs were
	found, but if they had added --use-dynamic to the command line
	then relocs would have been displayed.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index d0cd3c7..951807f 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2017-10-31  Nick Clifton  <nickc@redhat.com>
+
+       * readelf.c (process_relocs): Tell users if no static relocs were
+       found, but if they had added --use-dynamic to the command line
+       then relocs would have been displayed.
+
 2017-10-28  Alan Modra  <amodra@gmail.com>
 
        PR 22361

diff --git a/binutils/readelf.c b/binutils/readelf.c
index 58c28db..f74d484 100644 (file)
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -7150,7 +7150,21 @@ process_relocs (FILE * file)
        }
 
       if (! found)
-       printf (_("\nThere are no relocations in this file.\n"));
+       {
+         /* Users sometimes forget the -D option, so try to be helpful.  */
+         for (i = 0; i < ARRAY_SIZE (dynamic_relocations); i++)
+           {
+             if (dynamic_info [dynamic_relocations [i].size])
+               {
+                 printf (_("\nThere are no static relocations in this file."));
+                 printf (_("\nTo see the dynamic relocations add --use-dynamic to the command line.\n"));
+
+                 break;
+               }
+           }
+         if (i == ARRAY_SIZE (dynamic_relocations))
+           printf (_("\nThere are no relocations in this file.\n"));
+       }
     }
 
   return TRUE;