nvme-fc: remove double put reference if admin connect fails
authorJames Smart <jsmart2021@gmail.com>
Wed, 29 Nov 2017 23:11:37 +0000 (15:11 -0800)
committerChristoph Hellwig <hch@lst.de>
Fri, 15 Dec 2017 14:13:33 +0000 (15:13 +0100)
There are two put references in the failure case of initial
create_association. The first put actually frees the controller, thus the
second put references freed memory.

Remove the unnecessary 2nd put.

Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/fc.c

index 0a8af4d..794e66e 100644 (file)
@@ -3221,7 +3221,6 @@ nvme_fc_init_ctrl(struct device *dev, struct nvmf_ctrl_options *opts,
 
                /* initiate nvme ctrl ref counting teardown */
                nvme_uninit_ctrl(&ctrl->ctrl);
-               nvme_put_ctrl(&ctrl->ctrl);
 
                /* Remove core ctrl ref. */
                nvme_put_ctrl(&ctrl->ctrl);