Always use atom-shell as product name.

Since the symbols of atom-shell would be used by all third party
applications, it would make server handling more complicated if we allow
users to custom the uploaded product name. We should always use
atom-shell as product name when uploading so the server would not be
confused when searching symbols, and the user specified product name
could be show in UI.

diff --git a/common/crash_reporter/crash_reporter_mac.mm b/common/crash_reporter/crash_reporter_mac.mm
index 47b399d..72ae8c9 100644 (file)
--- a/common/crash_reporter/crash_reporter_mac.mm
+++ b/common/crash_reporter/crash_reporter_mac.mm
@@ -34,7 +34,7 @@ void CrashReporterMac::InitBreakpad(const std::string& product_name,
   NSMutableDictionary* parameters =
       [NSMutableDictionary dictionaryWithCapacity:4];
 
-  [parameters setValue:base::SysUTF8ToNSString(product_name)
+  [parameters setValue:@"atom-shell"
                 forKey:@BREAKPAD_PRODUCT];
   [parameters setValue:base::SysUTF8ToNSString(product_name)
                 forKey:@BREAKPAD_PRODUCT_DISPLAY];

diff --git a/spec/api/crash-reporter.coffee b/spec/api/crash-reporter.coffee
index b612356..0b5d145 100644 (file)
--- a/spec/api/crash-reporter.coffee
+++ b/spec/api/crash-reporter.coffee
@@ -13,7 +13,7 @@ describe 'crash-reporter module', ->
     server = http.createServer (req, res) ->
       form = new formidable.IncomingForm()
       form.parse req, (error, fields, files) ->
-        assert.equal fields['prod'], 'Atom-Shell'
+        assert.equal fields['prod'], 'atom-shell'
         assert.equal fields['ver'], process.versions['atom-shell']
         assert.equal fields['process_type'], 'renderer'
         assert.equal fields['platform'], process.platform