rxrpc: Fix an error goto in rxrpc_connect_call()

Fix an error-handling goto in rxrpc_connect_call() whereby it will jump to
free the bundle it failed to allocate.

Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>

diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c
index 0e4e1879c24d5d892652ae2ee01d5a673479dc48..180be4da8d2667485daace7b44d301b514cd2369 100644 (file)
--- a/net/rxrpc/conn_client.c
+++ b/net/rxrpc/conn_client.c
@@ -724,8 +724,9 @@ granted_channel:
        /* Paired with the write barrier in rxrpc_activate_one_channel(). */
        smp_rmb();
 
-out:
+out_put_bundle:
        rxrpc_put_bundle(bundle);
+out:
        _leave(" = %d", ret);
        return ret;
 
@@ -742,7 +743,7 @@ wait_failed:
        trace_rxrpc_client(call->conn, ret, rxrpc_client_chan_wait_failed);
        rxrpc_set_call_completion(call, RXRPC_CALL_LOCAL_ERROR, 0, ret);
        rxrpc_disconnect_client_call(bundle, call);
-       goto out;
+       goto out_put_bundle;
 }
 
 /*