ASoC: qdsp6: q6adm: fix cppcheck warnings for unnecessary initialization
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Mon, 9 Aug 2021 12:31:37 +0000 (13:31 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 9 Aug 2021 12:49:13 +0000 (13:49 +0100)
cppcheck reports below warning.

q6adm.c:475]: (style) Variable 'matrix_map' is reassigned a value before the
old one has been used.

This is due to unnecessary initialization of variable matrix_map, which is
now removed as part of this patch.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210809123137.14456-3-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6adm.c

index 1855b80..3d831b6 100644 (file)
@@ -465,7 +465,7 @@ int q6adm_matrix_map(struct device *dev, int path,
        struct apr_pkt *pkt;
        uint16_t *copps_list;
        int pkt_size, ret, i, copp_idx;
-       void *matrix_map = NULL;
+       void *matrix_map;
        struct q6copp *copp;
 
        /* Assumes port_ids have already been validated during adm_open */