efl_ui_selection: give this event a better name
authorMarcel Hollerbach <mail@marcel-hollerbach.de>
Wed, 20 Mar 2019 14:01:23 +0000 (15:01 +0100)
committerYeongjong Lee <yj34.lee@samsung.com>
Tue, 2 Apr 2019 03:45:17 +0000 (12:45 +0900)
this event does not get emitted when selection per se changes, it gets
emitted when the selection in the window manager changes. we should
prefix this even with that.

ref T7476

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8424

src/lib/elementary/efl_ui_selection.eo
src/lib/elementary/efl_ui_selection_manager.c

index 5dfedbfa9ae3c1fd6f222b5cb83e7a1cacabfbff..20e42261d075702ea18055c6d27bf00897703bc5 100644 (file)
@@ -40,6 +40,6 @@ mixin @beta Efl.Ui.Selection {
       }
    }
    events {
-      selection,changed: Efl.Ui.Selection_Changed; [[Called when display server's selection has changed]]
+      wm_selection,changed: Efl.Ui.Selection_Changed; [[Called when display server's selection has changed]]
    }
 }
index be74c25535bf9ab6d3e95347a5ebbd51451daba1..98926c09cc5d9fc521164423cf0be95fc8c6a3fb 100644 (file)
@@ -893,7 +893,7 @@ _x11_fixes_selection_notify(void *data, int t EINA_UNUSED, void *event)
    _e->exists = e.exist;
 
    ecore_event_add(ELM_CNP_EVENT_SELECTION_CHANGED, _e, NULL, NULL);
-   efl_event_callback_call(sel->owner, EFL_UI_SELECTION_EVENT_SELECTION_CHANGED, &e);
+   efl_event_callback_call(sel->owner, EFL_UI_SELECTION_EVENT_WM_SELECTION_CHANGED, &e);
 
    return ECORE_CALLBACK_RENEW;
 }
@@ -2679,7 +2679,7 @@ _wl_selection_changed(void *data, int type EINA_UNUSED, void *event)
    _e->exists = e.exist;
 
    ecore_event_add(ELM_CNP_EVENT_SELECTION_CHANGED, _e, _wl_selection_changed_free, ev->display);
-   efl_event_callback_call(sel->request_obj, EFL_UI_SELECTION_EVENT_SELECTION_CHANGED, &e);
+   efl_event_callback_call(sel->request_obj, EFL_UI_SELECTION_EVENT_WM_SELECTION_CHANGED, &e);
 
    return ECORE_CALLBACK_RENEW;
 }