ram: ast2600: Keep MPLL power on
authorDylan Hung <dylan_hung@aspeedtech.com>
Tue, 21 Feb 2023 13:01:09 +0000 (21:01 +0800)
committerTom Rini <trini@konsulko.com>
Mon, 6 Mar 2023 22:03:56 +0000 (17:03 -0500)
According to the PLL vendor, we should keep the PLL power on, so we
shouldn't toggle the power-down bit during PLL initialization.

Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
drivers/ram/aspeed/sdram_ast2600.c

index 1876755..d463933 100644 (file)
@@ -1089,13 +1089,13 @@ static int ast2600_sdrammc_probe(struct udevice *dev)
        }
 
        reg = readl(&priv->scu->mpll);
-       reg &= ~(SCU_PLL_BYPASS | SCU_PLL_DIV_MASK |
+       reg &= ~(SCU_PLL_BYPASS | SCU_PLL_OFF | SCU_PLL_DIV_MASK |
                 SCU_PLL_DENUM_MASK | SCU_PLL_NUM_MASK);
-       reg |= (SCU_PLL_RST | SCU_PLL_OFF | SCU_MPLL_FREQ_CFG);
+       reg |= (SCU_PLL_RST | SCU_MPLL_FREQ_CFG);
        writel(reg, &priv->scu->mpll);
        writel(SCU_MPLL_EXT_CFG, &priv->scu->mpll_ext);
        udelay(100);
-       reg &= ~(SCU_PLL_RST | SCU_PLL_OFF);
+       reg &= ~SCU_PLL_RST;
        writel(reg, &priv->scu->mpll);
 
        while ((readl(&priv->scu->mpll_ext) & BIT(31)) == 0)