Plug memleak from %pretrans

- te->fi needs to be freed if we replace it...

diff --git a/lib/transaction.c b/lib/transaction.c
index 7e432a3..1f99384 100644 (file)
--- a/lib/transaction.c
+++ b/lib/transaction.c
@@ -898,7 +898,6 @@ static int runTransScripts(rpmts ts, rpmTag stag)
            script = fi->posttrans;
            scriptprog = fi->posttransprog;
            progtag = RPMTAG_POSTTRANSPROG;
-           p->fi = rpmfiFree(p->fi);
            break;
        default:
            /* programmer error, blow up */
@@ -934,6 +933,7 @@ static int runTransScripts(rpmts ts, rpmTag stag)
         }
 
        if (rpmteFd(p) != NULL) {
+           p->fi = rpmfiFree(p->fi);
            fi = rpmfiNew(ts, p->h, RPMTAG_BASENAMES, 1);
            if (fi != NULL) {   /* XXX can't happen */
                if (stag == RPMTAG_PRETRANS) {