drm/qxl: remove set but not used variable 'map'
authorYueHaibing <yuehaibing@huawei.com>
Sat, 10 Nov 2018 03:44:46 +0000 (03:44 +0000)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 14 Nov 2018 13:21:04 +0000 (14:21 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
 variable 'map' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1541821486-40631-1-git-send-email-yuehaibing@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/qxl/qxl_object.c

index f67a3c5..b1706cb 100644 (file)
@@ -186,13 +186,9 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
                               struct qxl_bo *bo, void *pmap)
 {
        struct ttm_mem_type_manager *man = &bo->tbo.bdev->man[bo->tbo.mem.mem_type];
-       struct io_mapping *map;
 
-       if (bo->tbo.mem.mem_type == TTM_PL_VRAM)
-               map = qdev->vram_mapping;
-       else if (bo->tbo.mem.mem_type == TTM_PL_PRIV)
-               map = qdev->surface_mapping;
-       else
+       if ((bo->tbo.mem.mem_type != TTM_PL_VRAM) &&
+           (bo->tbo.mem.mem_type != TTM_PL_PRIV))
                goto fallback;
 
        io_mapping_unmap_atomic(pmap);
@@ -200,7 +196,7 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
        (void) ttm_mem_io_lock(man, false);
        ttm_mem_io_free(bo->tbo.bdev, &bo->tbo.mem);
        ttm_mem_io_unlock(man);
-       return ;
+       return;
  fallback:
        qxl_bo_kunmap(bo);
 }