Cleanup of clang's static analyzer warnings for efreet.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/efreet@40114 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/bin/ef_desktop.c b/src/bin/ef_desktop.c
index 4712f33..7c40974 100644 (file)
--- a/src/bin/ef_desktop.c
+++ b/src/bin/ef_desktop.c
@@ -302,8 +302,8 @@ ef_cb_desktop_command_get(void)
 
     /* clean up */
     efreet_desktop_free(desktop);
-    files = eina_list_free(files);
-    expected = eina_list_free(expected);
+    eina_list_free(files);
+    eina_list_free(expected);
 
     ret = info->error > 0 ? 0 : 1;
     free(info);

diff --git a/src/lib/efreet_base.c b/src/lib/efreet_base.c
index d60d21f..679d645 100644 (file)
--- a/src/lib/efreet_base.c
+++ b/src/lib/efreet_base.c
@@ -108,7 +108,7 @@ efreet_config_home_get(void)
 
 /**
  * @return Returns the Eina_List of preference ordered extra config directories
- * @brief Returns the Eina_List of prefernece oredred extra config
+ * @brief Returns the Eina_List of prefernece ordered extra config
  * directories
  *
  * @note The returned list is static inside Efreet. If you add/remove from the

diff --git a/src/lib/efreet_icon.c b/src/lib/efreet_icon.c
index 1bb24e9..02c3fac 100644 (file)
--- a/src/lib/efreet_icon.c
+++ b/src/lib/efreet_icon.c
@@ -1062,7 +1062,6 @@ efreet_icon_populate(Efreet_Icon *icon, const char *file)
 
         t = strdup(tmp);
         s = t;
-        p = t;
         while (s)
         {
             Efreet_Icon_Point *point;

diff --git a/src/lib/efreet_menu.c b/src/lib/efreet_menu.c
index b6406e0..3b395f1 100644 (file)
--- a/src/lib/efreet_menu.c
+++ b/src/lib/efreet_menu.c
@@ -670,8 +670,6 @@ efreet_menu_parse(const char *path)
     internal->inline_header = 1;
     internal->inline_alias = 0;
 
-    search_dirs = efreet_config_dirs_get();
-
     efreet_menu_path_set(internal, path);
     if (!efreet_menu_handle_menu(internal, xml))
     {

diff --git a/src/lib/efreet_utils.c b/src/lib/efreet_utils.c
index 41df840..9146e8d 100644 (file)
--- a/src/lib/efreet_utils.c
+++ b/src/lib/efreet_utils.c
@@ -187,9 +187,6 @@ efreet_util_path_in_default(const char *section, const char *path)
 
     EINA_LIST_FREE(dirs, dir)
     {
-        size_t len;
-
-        len = strlen(dir);
         if (!strncmp(path, dir, strlen(dir)))
         {
             ret = dir;