Code cleanup

Removes comments that will not be fixed and "empty method" comment
that gives no information at all.

Change-Id: I299a7fe88a0f1bab2d336c462e0dc7cb13f92217

diff --git a/src/common/step/step_backup_icons.h b/src/common/step/step_backup_icons.h
index 49de070..cb9f1e9 100644 (file)
--- a/src/common/step/step_backup_icons.h
+++ b/src/common/step/step_backup_icons.h
@@ -45,11 +45,6 @@ class StepBackupIcons : public Step {
    */
   Status undo() override;
 
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status precheck() override { return Status::OK; }
 
  private:

diff --git a/src/common/step/step_backup_manifest.h b/src/common/step/step_backup_manifest.h
index b06ef7b..b96ce36 100644 (file)
--- a/src/common/step/step_backup_manifest.h
+++ b/src/common/step/step_backup_manifest.h
@@ -42,11 +42,6 @@ class StepBackupManifest : public Step {
    */
   Status undo() override;
 
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status precheck() override;
 
   SCOPE_LOG_TAG(BackupManifest)

diff --git a/src/common/step/step_check_old_certificate.h b/src/common/step/step_check_old_certificate.h
index 8a9ff3c..ab3179a 100644 (file)
--- a/src/common/step/step_check_old_certificate.h
+++ b/src/common/step/step_check_old_certificate.h
@@ -27,26 +27,8 @@ class StepCheckOldCertificate : public Step {
    * \return Status::OK if certificates are OK. ERROR otherwise
    */
   Status process() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status undo() override { return Status::OK; }
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status precheck() override { return Status::OK; }
 
   SCOPE_LOG_TAG(CheckOldCertificate)

diff --git a/src/common/step/step_check_signature.h b/src/common/step/step_check_signature.h
index a0305f3..27518b0 100644 (file)
--- a/src/common/step/step_check_signature.h
+++ b/src/common/step/step_check_signature.h
@@ -30,18 +30,8 @@ class StepCheckSignature : public Step {
    */
   Status process() override;
 
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status undo() override { return Status::OK; }
 
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
 
   /**

diff --git a/src/common/step/step_configure.h b/src/common/step/step_configure.h
index 58e832c..a6add86 100644 (file)
--- a/src/common/step/step_configure.h
+++ b/src/common/step/step_configure.h
@@ -45,11 +45,6 @@ class StepConfigure : public Step {
    */
   Status clean() override;
 
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status undo() override { return Status::OK; }
 
   /**

diff --git a/src/common/step/step_copy.h b/src/common/step/step_copy.h
index f646dae..8dc4d6d 100644 (file)
--- a/src/common/step/step_copy.h
+++ b/src/common/step/step_copy.h
@@ -31,11 +31,6 @@ class StepCopy : public Step {
    */
   Status process() override;
 
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
 
   /**

diff --git a/src/common/step/step_copy_storage_directories.h b/src/common/step/step_copy_storage_directories.h
index 2c08f34..d4bee56 100644 (file)
--- a/src/common/step/step_copy_storage_directories.h
+++ b/src/common/step/step_copy_storage_directories.h
@@ -29,12 +29,6 @@ class StepCopyStorageDirectories : public common_installer::Step {
    * \return Status::OK if success, Status::ERROR otherwise
    */
   Status process() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
 
   /**

diff --git a/src/common/step/step_copy_tep.h b/src/common/step/step_copy_tep.h
index 8d16319..d38f616 100644 (file)
--- a/src/common/step/step_copy_tep.h
+++ b/src/common/step/step_copy_tep.h
@@ -30,12 +30,6 @@ class StepCopyTep : public Step {
    * \return Status::OK if success, Status::ERROR otherwise
    */
   Status process() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
 
   /**

diff --git a/src/common/step/step_create_icons.h b/src/common/step/step_create_icons.h
index 7d25971..1f0981c 100644 (file)
--- a/src/common/step/step_create_icons.h
+++ b/src/common/step/step_create_icons.h
@@ -33,26 +33,13 @@ class StepCreateIcons : public Step {
    * \return Status::OK if success, Status::ERROR otherwise
    */
   Status process() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
-
   /**
    * \brief removes icons from system
    *
    * \return Status::OK
    */
   Status undo() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status precheck() override { return Status::OK; }
 
  private:

diff --git a/src/common/step/step_fail.h b/src/common/step/step_fail.h
index 0619660..3947470 100644 (file)
--- a/src/common/step/step_fail.h
+++ b/src/common/step/step_fail.h
@@ -28,26 +28,8 @@ class StepFail : public Step {
    * \return Status::ERROR
    */
   Status process() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status undo() override { return Status::OK; }
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status precheck() override { return Status::OK; }
 
   SCOPE_LOG_TAG(Fail)

diff --git a/src/common/step/step_kill_apps.h b/src/common/step/step_kill_apps.h
index 90c9173..e276187 100644 (file)
--- a/src/common/step/step_kill_apps.h
+++ b/src/common/step/step_kill_apps.h
@@ -28,19 +28,7 @@ class StepKillApps : public Step {
    * \return Status::OK
    */
   Status process() override;
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status clean() override { return Status::OK; }
-
-  /**
-   * \brief empty method
-   *
-   * \return Status::OK
-   */
   Status undo() override { return Status::OK; }
 
   /**

diff --git a/src/common/step/step_register_app.cc b/src/common/step/step_register_app.cc
index 00ef6af..17b7275 100644 (file)
--- a/src/common/step/step_register_app.cc
+++ b/src/common/step/step_register_app.cc
@@ -25,7 +25,6 @@ Step::Status StepRegisterApplication::precheck() {
                << ") path does not exist";
     return Step::Status::MANIFEST_NOT_FOUND;
   }
-  // TODO(p.sikorski) check context_->uid.get()
 
   return Step::Status::OK;
 }

diff --git a/src/common/step/step_remove_files.cc b/src/common/step/step_remove_files.cc
index 19ff998..3433873 100644 (file)
--- a/src/common/step/step_remove_files.cc
+++ b/src/common/step/step_remove_files.cc
@@ -28,7 +28,6 @@ Step::Status StepRemoveFiles::precheck() {
     LOG(ERROR) << "pkg_path ("
                << context_->pkg_path.get()
                << ") path does not exist";
-  // TODO(p.sikorski) check context_->uid.get()
 
   return Step::Status::OK;
 }

diff --git a/src/common/step/step_unregister_app.cc b/src/common/step/step_unregister_app.cc
index 5f34b1d..84ed4b5 100644 (file)
--- a/src/common/step/step_unregister_app.cc
+++ b/src/common/step/step_unregister_app.cc
@@ -38,8 +38,6 @@ Step::Status StepUnregisterApplication::precheck() {
     return Status::MANIFEST_NOT_FOUND;
   }
 
-  // TODO(p.sikorski) check context_->uid.get()
-
   return Step::Status::OK;
 }
 

diff --git a/src/common/step/step_unzip.cc b/src/common/step/step_unzip.cc
index 09a7c3a..f04dbdd 100644 (file)
--- a/src/common/step/step_unzip.cc
+++ b/src/common/step/step_unzip.cc
@@ -69,9 +69,6 @@ Step::Status StepUnzip::precheck() {
     LOG(ERROR) << "root_application_path ("
                << context_->root_application_path.get()
                << ") path does not exist";
-    // TODO(p.sikorski) maybe it should be created (instead of returning error)
-    // but, if so, then it should be created in a separate step, eg.
-    // AppInstallerConfigure or something similar
     return Step::Status::INVALID_VALUE;
   }