Don't leak URLFetcher

diff --git a/atom/browser/net/url_request_fetch_job.cc b/atom/browser/net/url_request_fetch_job.cc
index 081e85f..3f4ef06 100644 (file)
--- a/atom/browser/net/url_request_fetch_job.cc
+++ b/atom/browser/net/url_request_fetch_job.cc
@@ -24,14 +24,12 @@ URLRequestFetchJob::URLRequestFetchJob(
 URLRequestFetchJob::~URLRequestFetchJob() {}
 
 void URLRequestFetchJob::Start() {
-  net::URLFetcher* fetcher = net::URLFetcher::Create(url_,
-                                                     net::URLFetcher::GET,
-                                                     this);
+  fetcher_.reset(net::URLFetcher::Create(url_, net::URLFetcher::GET, this));
   auto context = AtomBrowserContext::Get()->url_request_context_getter();
-  fetcher->SetRequestContext(context);
-  fetcher->SaveResponseWithWriter(scoped_ptr<net::URLFetcherResponseWriter>(
+  fetcher_->SetRequestContext(context);
+  fetcher_->SaveResponseWithWriter(scoped_ptr<net::URLFetcherResponseWriter>(
       this));
-  fetcher->Start();
+  fetcher_->Start();
 }
 
 void URLRequestFetchJob::Kill() {

diff --git a/atom/browser/net/url_request_fetch_job.h b/atom/browser/net/url_request_fetch_job.h
index e955341..69726f9 100644 (file)
--- a/atom/browser/net/url_request_fetch_job.h
+++ b/atom/browser/net/url_request_fetch_job.h
@@ -45,6 +45,7 @@ class URLRequestFetchJob : public net::URLRequestJob,
 
  private:
   GURL url_;
+  scoped_ptr<net::URLFetcher> fetcher_;
   scoped_refptr<net::DrainableIOBuffer> buffer_;
 
   base::WeakPtrFactory<URLRequestFetchJob> weak_ptr_factory_;