2007-07-26 Michael Snyder <msnyder@access-company.com>

	* coffgen.c (_bfd_coff_read_internal_relocs): If internal_relocs
	are not to be cached, free the temporary buffer.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 4fd7f4a..54ef404 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,8 @@
 2007-07-26  Michael Snyder  <msnyder@access-company.com>
 
+       * coffgen.c (_bfd_coff_read_internal_relocs): If internal_relocs
+       are not to be cached, free the temporary buffer.
+
        * aoutx.h (slurp_reloc_table): Return TRUE if reloc_size == zero
        or count == zero.
 

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index f4f97b3..7fad78c 100644 (file)
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -457,17 +457,22 @@ _bfd_coff_read_internal_relocs (bfd *abfd,
       free_external = NULL;
     }
 
-  if (cache && free_internal != NULL)
+  if (free_internal != NULL)
     {
-      if (coff_section_data (abfd, sec) == NULL)
+      if (cache)
+       free (free_internal);
+      else
        {
-         amt = sizeof (struct coff_section_tdata);
-         sec->used_by_bfd = bfd_zalloc (abfd, amt);
-         if (sec->used_by_bfd == NULL)
-           goto error_return;
-         coff_section_data (abfd, sec)->contents = NULL;
+         if (coff_section_data (abfd, sec) == NULL)
+           {
+             amt = sizeof (struct coff_section_tdata);
+             sec->used_by_bfd = bfd_zalloc (abfd, amt);
+             if (sec->used_by_bfd == NULL)
+               goto error_return;
+             coff_section_data (abfd, sec)->contents = NULL;
+           }
+         coff_section_data (abfd, sec)->relocs = free_internal;
        }
-      coff_section_data (abfd, sec)->relocs = free_internal;
     }
 
   return internal_relocs;