fs/ntfs3: Correct mode for label entry inside /proc/fs/ntfs3/
authorKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Fri, 30 Jun 2023 11:23:07 +0000 (15:23 +0400)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Sun, 2 Jul 2023 20:21:30 +0000 (00:21 +0400)
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/super.c

index e36769e..1a02072 100644 (file)
@@ -1548,11 +1548,12 @@ load_root:
        /* Create /proc/fs/ntfs3/.. */
        if (proc_info_root) {
                struct proc_dir_entry *e = proc_mkdir(sb->s_id, proc_info_root);
+               static_assert((S_IRUGO | S_IWUSR) == 0644);
                if (e) {
-                       proc_create_data("volinfo", S_IFREG | S_IRUGO, e,
+                       proc_create_data("volinfo", S_IRUGO, e,
                                         &ntfs3_volinfo_fops, sb);
-                       proc_create_data("label", S_IFREG | S_IRUGO | S_IWUGO,
-                                        e, &ntfs3_label_fops, sb);
+                       proc_create_data("label", S_IRUGO | S_IWUSR, e,
+                                        &ntfs3_label_fops, sb);
                        sbi->procdir = e;
                }
        }