Fix SkIStream nits.
authorbungeman <bungeman@google.com>
Thu, 22 Jan 2015 15:33:51 +0000 (07:33 -0800)
committerCommit bot <commit-bot@chromium.org>
Thu, 22 Jan 2015 15:33:51 +0000 (07:33 -0800)
Fix comment, constness of one field, and delete already checks for NULL.

TBR=reed@google.com
Trivial change to debatably public api.

Review URL: https://codereview.chromium.org/868643003

include/utils/win/SkIStream.h
src/utils/win/SkIStream.cpp

index e2c2b96..9e04b7e 100644 (file)
@@ -75,12 +75,12 @@ public:
 };
 
 /**
- * A minimal read-only IStream implementation which wraps an SkIStream.
+ * A minimal read-only IStream implementation which wraps an SkStream.
  */
 class SkIStream : public SkBaseIStream {
 private:
     SkStream *fSkStream;
-    bool fDeleteOnRelease;
+    const bool fDeleteOnRelease;
     ULARGE_INTEGER fLocation;
 
     SkIStream(SkStream* stream, bool fDeleteOnRelease);
index 2e9510c..dc9d163 100644 (file)
@@ -113,7 +113,7 @@ SkIStream::SkIStream(SkStream* stream, bool deleteOnRelease)
 }
 
 SkIStream::~SkIStream() {
-    if (this->fSkStream && fDeleteOnRelease) {
+    if (fDeleteOnRelease) {
         delete this->fSkStream;
     }
 }