This patch is now The Right Way(tm) to handle the stop button but at least it doesn...

Original commit message from CVS:
This patch is now The Right Way(tm) to handle the stop button but at
least it doesn't crash...

diff --git a/gstplay/gstmediaplay.glade b/gstplay/gstmediaplay.glade
index c24f689..ba39ffb 100644 (file)
--- a/gstplay/gstmediaplay.glade
+++ b/gstplay/gstmediaplay.glade
@@ -405,7 +405,8 @@
   <authors>Erik Walthinsen &lt;omega@cse.ogi.edu&gt;,
 Wim Taymans &lt;wim.taymans@tvd.be&gt;,
 Richard Boulton &lt;richard@tartarus.org&gt;,
-Chris Emerson (PPC port)
+Chris Emerson (PPC port),
+Ronald Bultje &lt;rbultje@ronald.bitfreak.net&gt;
 </authors>
   <comments>A generic media player for the gstreamer streaming media framework.</comments>
 </widget>

diff --git a/gstplay/gstplay.c b/gstplay/gstplay.c
index 0b25d77..aa56b79 100644 (file)
--- a/gstplay/gstplay.c
+++ b/gstplay/gstplay.c
@@ -462,9 +462,10 @@ gst_play_stop (GstPlay *play)
 
   priv = (GstPlayPrivate *)play->priv;
 
-  gst_element_set_state (GST_ELEMENT (priv->thread),GST_STATE_PAUSED);
+  // FIXME until state changes are handled properly
+  gst_element_set_state (GST_ELEMENT (priv->thread),GST_STATE_READY);
   gtk_object_set (GTK_OBJECT (priv->src),"offset",0,NULL);
-  gst_element_set_state (GST_ELEMENT (priv->thread),GST_STATE_NULL);
+  //gst_element_set_state (GST_ELEMENT (priv->thread),GST_STATE_NULL);
 
   play->state = GST_PLAY_STOPPED;