NFC: NCI: Fix NULL pointer dereference
authorAmitkumar Karwar <akarwar@marvell.com>
Thu, 6 Feb 2014 19:28:31 +0000 (11:28 -0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 23 Feb 2014 22:14:45 +0000 (23:14 +0100)
The check should be for setup function pointer.

This patch fixes NULL pointer dereference issue for NCI
based NFC driver which doesn't define setup handler.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/nci/core.c

index 46bda01..56db888 100644 (file)
@@ -301,7 +301,7 @@ static int nci_open_device(struct nci_dev *ndev)
        rc = __nci_request(ndev, nci_reset_req, 0,
                           msecs_to_jiffies(NCI_RESET_TIMEOUT));
 
-       if (ndev->ops->setup(ndev))
+       if (ndev->ops->setup)
                ndev->ops->setup(ndev);
 
        if (!rc) {