handle: fix memleak on error path
authorRui Miguel Silva <rmfrfs@gmail.com>
Wed, 14 Jan 2015 11:09:35 +0000 (11:09 +0000)
committerDavid Herrmann <dh.herrmann@gmail.com>
Wed, 14 Jan 2015 12:51:22 +0000 (13:51 +0100)
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
handle.c

index d43db6de08b5d5a9e2c045b1a24b2d9a42720b22..129c51b0b8ed1ce1d6c5e187e889bda0ae743250 100644 (file)
--- a/handle.c
+++ b/handle.c
@@ -165,8 +165,10 @@ static int handle_ep_ioctl_endpoint_make(struct kdbus_handle_ep *handle,
 
        make->return_flags = 0;
        if (kdbus_member_set_user(&make->return_flags, buf,
-                                 struct kdbus_cmd_make, return_flags))
-               return -EFAULT;
+                                 struct kdbus_cmd_make, return_flags)) {
+               ret = -EFAULT;
+               goto exit;
+       }
 
        ret = kdbus_negotiate_flags(make, buf, struct kdbus_cmd_make,
                                    KDBUS_MAKE_ACCESS_GROUP |