pulsesink: check pointer before accessing
authorStefan Kost <ensonic@users.sf.net>
Wed, 3 Jun 2009 15:23:53 +0000 (18:23 +0300)
committerStefan Kost <ensonic@users.sf.net>
Wed, 3 Jun 2009 15:23:53 +0000 (18:23 +0300)
Move existing check a few lines up, so that we check before accessing fields.

ext/pulse/pulsesink.c

index acb0062..36d5b1b 100644 (file)
@@ -1718,12 +1718,12 @@ gst_pulsesink_change_title (GstPulseSink * psink, const gchar * t)
 
   pbuf = GST_PULSERING_BUFFER_CAST (GST_BASE_AUDIO_SINK (psink)->ringbuffer);
 
-  g_free (pbuf->stream_name);
-  pbuf->stream_name = g_strdup (t);
-
   if (pbuf == NULL || pbuf->stream == NULL)
     goto no_buffer;
 
+  g_free (pbuf->stream_name);
+  pbuf->stream_name = g_strdup (t);
+
   if (!(o = pa_stream_set_name (pbuf->stream, pbuf->stream_name, NULL, NULL)))
     goto name_failed;