arm64: stacktrace: use non-atomic __set_bit
authorAndrey Konovalov <andreyknvl@google.com>
Mon, 23 May 2022 14:51:52 +0000 (16:51 +0200)
committerWill Deacon <will@kernel.org>
Thu, 23 Jun 2022 14:57:29 +0000 (15:57 +0100)
Use the non-atomic version of set_bit() in arch/arm64/kernel/stacktrace.c,
as there is no concurrent accesses to frame->prev_type.

This speeds up stack trace collection and improves the boot time of
Generic KASAN by 2-5%.

Suggested-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Link: https://lore.kernel.org/r/23dfa36d1cc91e4a1059945b7834eac22fb9854d.1653317461.git.andreyknvl@google.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/stacktrace.c

index c246e8d..d6bef10 100644 (file)
@@ -117,7 +117,7 @@ static int notrace unwind_next(struct task_struct *tsk,
                if (fp <= state->prev_fp)
                        return -EINVAL;
        } else {
-               set_bit(state->prev_type, state->stacks_done);
+               __set_bit(state->prev_type, state->stacks_done);
        }
 
        /*