soc: qcom: mdt_loader: Use request_firmware_into_buf()
authorBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 26 Jun 2017 20:36:59 +0000 (13:36 -0700)
committerAndy Gross <andy.gross@linaro.org>
Tue, 8 Aug 2017 22:41:23 +0000 (17:41 -0500)
By switching to the request_firmware_into_buf() we load the segment data
straight into the preallocated buffers, reducing the need for allocating
scratch buffers for these. In particular the modem firmware consists of
multiple segments in the range 5-15MB, making this worth while.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
drivers/soc/qcom/mdt_loader.c

index bd63df0..08bd854 100644 (file)
@@ -178,14 +178,13 @@ int qcom_mdt_load(struct device *dev, const struct firmware *fw,
 
                if (phdr->p_filesz) {
                        sprintf(fw_name + fw_name_len - 3, "b%02d", i);
-                       ret = request_firmware(&seg_fw, fw_name, dev);
+                       ret = request_firmware_into_buf(&seg_fw, fw_name, dev,
+                                                       ptr, phdr->p_filesz);
                        if (ret) {
                                dev_err(dev, "failed to load %s\n", fw_name);
                                break;
                        }
 
-                       memcpy(ptr, seg_fw->data, seg_fw->size);
-
                        release_firmware(seg_fw);
                }