leds: led-class: Add missing put_device() to led_put()

led_put() is used to "undo" a successful of_led_get() call,
of_led_get() uses class_find_device_by_of_node() which returns
a reference to the device which must be free-ed with put_device()
when the caller is done with it.

Add a put_device() call to led_put() to free the reference returned
by class_find_device_by_of_node().

And also add a put_device() in the error-exit case of try_module_get()
failing.

Fixes: 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230120114524.408368-2-hdegoede@redhat.com

diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 6a8ea94834fa3abf258ca33d1218d4af4e312725..7391d2cf1370a9c4a4d91b01799902977be3a997 100644 (file)
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -241,8 +241,10 @@ struct led_classdev *of_led_get(struct device_node *np, int index)
 
        led_cdev = dev_get_drvdata(led_dev);
 
-       if (!try_module_get(led_cdev->dev->parent->driver->owner))
+       if (!try_module_get(led_cdev->dev->parent->driver->owner)) {
+               put_device(led_cdev->dev);
                return ERR_PTR(-ENODEV);
+       }
 
        return led_cdev;
 }
@@ -255,6 +257,7 @@ EXPORT_SYMBOL_GPL(of_led_get);
 void led_put(struct led_classdev *led_cdev)
 {
        module_put(led_cdev->dev->parent->driver->owner);
+       put_device(led_cdev->dev);
 }
 EXPORT_SYMBOL_GPL(led_put);