staging: rtl8723au: else is not generally useful after a return
authorM. Vefa Bicakci <m.v.b@runbox.com>
Sun, 29 Mar 2015 01:07:49 +0000 (21:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Apr 2015 13:25:45 +0000 (15:25 +0200)
Correct a checkpatch.pl warning regarding rtl8723au's
rtw_security.c::crc32_init pointing out that having an else statement
after a break or a return is not useful.

drivers/staging/rtl8723au/core/rtw_security.c:105:
WARNING: else is not generally useful after a break or return

Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/core/rtw_security.c

index df7261c..b85e5de 100644 (file)
@@ -99,31 +99,33 @@ static u8 crc32_reverseBit(u8 data)
 
 static void crc32_init(void)
 {
+       int i, j;
+       u32 c;
+       u8 *p, *p1;
+       u8 k;
 
        if (bcrc32initialized == 1)
                return;
-       else{
-               int i, j;
-               u32 c;
-               u8 *p = (u8 *)&c, *p1;
-               u8 k;
-
-               c = 0x12340000;
-
-               for (i = 0; i < 256; ++i) {
-                       k = crc32_reverseBit((u8)i);
-                       for (c = ((u32)k) << 24, j = 8; j > 0; --j) {
-                               c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
-                       }
-                       p1 = (u8 *)&crc32_table[i];
-
-                       p1[0] = crc32_reverseBit(p[3]);
-                       p1[1] = crc32_reverseBit(p[2]);
-                       p1[2] = crc32_reverseBit(p[1]);
-                       p1[3] = crc32_reverseBit(p[0]);
+
+       p = (u8 *) &c;
+       c = 0x12340000;
+
+       for (i = 0; i < 256; ++i) {
+               k = crc32_reverseBit((u8)i);
+
+               for (c = ((u32)k) << 24, j = 8; j > 0; --j) {
+                       c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
                }
-               bcrc32initialized = 1;
+
+               p1 = (u8 *)&crc32_table[i];
+
+               p1[0] = crc32_reverseBit(p[3]);
+               p1[1] = crc32_reverseBit(p[2]);
+               p1[2] = crc32_reverseBit(p[1]);
+               p1[3] = crc32_reverseBit(p[0]);
        }
+
+       bcrc32initialized = 1;
 }
 
 static u32 getcrc32(u8 *buf, int len)