tools/power/x86/intel-speed-select: Fix high priority core mask over count
authorYouquan Song <youquan.song@intel.com>
Sat, 14 Sep 2019 19:45:43 +0000 (12:45 -0700)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 19 Sep 2019 11:51:29 +0000 (14:51 +0300)
If the CPU package has the less logical CPU than topo_max_cpus, but un-present
CPU's punit_cpu_core will be initiated to 0 and they will be count to core 0

Like below, there are only 10 high priority cores (20 logical CPUs) in the CPU
package, but it count to 27 logic CPUs.

./intel-speed-select base-freq info -l 0 | grep mask
        high-priority-cpu-mask:7f000179,f000179f

With the fix patch:
./intel-speed-select base-freq info -l 0
        high-priority-cpu-mask:00000179,f000179f

Signed-off-by: Youquan Song <youquan.song@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
tools/power/x86/intel-speed-select/isst-config.c

index 59753b3..83ac729 100644 (file)
@@ -402,6 +402,9 @@ void set_cpu_mask_from_punit_coremask(int cpu, unsigned long long core_mask,
                        int j;
 
                        for (j = 0; j < topo_max_cpus; ++j) {
+                               if (!CPU_ISSET_S(j, present_cpumask_size, present_cpumask))
+                                       continue;
+
                                if (cpu_map[j].pkg_id == pkg_id &&
                                    cpu_map[j].die_id == die_id &&
                                    cpu_map[j].punit_cpu_core == i) {