projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f25335a
)
drm/qxl: qxl_release leak in qxl_draw_dirty_fb()
author
Vasily Averin
<vvs@virtuozzo.com>
Mon, 27 Apr 2020 05:32:46 +0000
(08:32 +0300)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 6 May 2020 06:15:04 +0000
(08:15 +0200)
commit
85e9b88af1e6164f19ec71381efd5e2bcfc17620
upstream.
ret should be changed to release allocated struct qxl_release
Cc: stable@vger.kernel.org
Fixes:
8002db6336dd
("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Link:
http://patchwork.freedesktop.org/patch/msgid/22cfd55f-07c8-95d0-a2f7-191b7153c3d4@virtuozzo.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/qxl/qxl_draw.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/qxl/qxl_draw.c
b/drivers/gpu/drm/qxl/qxl_draw.c
index
5bebf1e
..
f8776d6
100644
(file)
--- a/
drivers/gpu/drm/qxl/qxl_draw.c
+++ b/
drivers/gpu/drm/qxl/qxl_draw.c
@@
-209,9
+209,10
@@
void qxl_draw_dirty_fb(struct qxl_device *qdev,
goto out_release_backoff;
rects = drawable_set_clipping(qdev, num_clips, clips_bo);
- if (!rects)
+ if (!rects) {
+ ret = -EINVAL;
goto out_release_backoff;
-
+ }
drawable = (struct qxl_drawable *)qxl_release_map(qdev, release);
drawable->clip.type = SPICE_CLIP_TYPE_RECTS;