clockselect: Remove non-sense comment
authorEderson de Souza <ederson.desouza@intel.com>
Mon, 27 Jan 2020 23:16:12 +0000 (15:16 -0800)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 30 Apr 2020 19:21:37 +0000 (19:21 +0000)
Commentary appears to assume `gst_harness_find_element` return value was
"transfer none", but it is not the case. So, element must be unrefed
before the end.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1009>

tests/check/elements/clockselect.c

index 206d678..485f50f 100644 (file)
@@ -39,8 +39,6 @@ GST_START_TEST (test_clock_select_realtime_clock)
   g_object_get (G_OBJECT (clock), "clock-type", &clock_type, NULL);
   fail_unless_equals_uint64 (clock_type, GST_CLOCK_TYPE_REALTIME);
 
-  /* Unref this element to shut up valgrind. But it looks weird, maybe
-   * some funny harness bug due clockselect being a bin? */
   gst_object_unref (element);
   gst_object_unref (clock);
   gst_harness_teardown (h);
@@ -65,7 +63,6 @@ GST_START_TEST (test_clock_select_monotonic_clock)
   g_object_get (G_OBJECT (clock), "clock-type", &clock_type, NULL);
   fail_unless_equals_uint64 (clock_type, GST_CLOCK_TYPE_MONOTONIC);
 
-  /* See comment on test_clock_select_realtime_clock about this unref */
   gst_object_unref (element);
   gst_object_unref (clock);
   gst_harness_teardown (h);
@@ -89,7 +86,6 @@ GST_START_TEST (test_clock_select_properties)
   g_object_get (G_OBJECT (element), "ptp-domain", &domain, NULL);
   fail_unless_equals_uint64 (domain, 2);
 
-  /* See comment on test_clock_select_realtime_clock about this unref */
   gst_object_unref (element);
   gst_harness_teardown (h);
 }