affected_file_path = affected_file.LocalPath()
file_path, file_ext = os.path.splitext(affected_file_path)
# We only care about files that end in .h and are under the top-level
- # include dir, but not include/private.
- if (file_ext == '.h' and
- 'include' == file_path.split(os.path.sep)[0] and
- 'private' not in file_path):
+ # include dir.
+ if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]:
requires_owner_check = True
if not requires_owner_check:
if not lgtm_from_owner:
results.append(
output_api.PresubmitError(
- "If this CL adds to or changes Skia's public API, you need an LGTM "
- "from any of %s. If this CL only removes from or doesn't change "
- "Skia's public API, please add a short note to your CL saying so "
- "and add one of those reviewers on a TBR= line. If you don't know "
- "this CL affects Skia's public API, please treat it like it does."
- % str(PUBLIC_API_OWNERS)))
+ 'Since the CL is editing public API, you must have an LGTM from '
+ 'one of: %s' % str(PUBLIC_API_OWNERS)))
return results
'target_name': 'SampleApp',
'type': 'executable',
'include_dirs' : [
- '../include/private',
'../src/core',
'../src/effects', #needed for BlurMask.h
'../src/gpu', # needed by SkLua.cpp
'include_dirs': [
'../bench/subset',
'../bench',
- '../include/private',
'../src/core',
'../src/effects',
'../src/gpu',
'../include/pathops',
'../include/pipe',
'../include/ports',
- '../include/private',
'../include/utils',
'../include/images',
'../src/core',
'/Library/Frameworks',
],
'include_dirs' : [
- '../include/private',
'../src/core',
'../src/utils/debugger',
'../debugger', # To pull SkDebugger.h
'include_dirs': [
'../dm',
'../gm',
- '../include/private',
'../src/core',
'../src/effects',
'../src/images',
],
'include_dirs': [
'../include/effects',
- '../include/private',
'../src/effects',
'../src/opts',
'../src/core',
'target_name': 'HelloWorld',
'type': 'executable',
'include_dirs' : [
- '../include/private',
'../include/gpu',
],
'sources': [
],
'include_dirs': [
'../include/gpu',
- '../include/private',
'../src/core',
'../src/gpu',
'../src/image/',
],
'include_dirs': [
'../include/gpu',
- '../include/private',
'../include/utils',
'../src/core',
'../src/gpu',
'pdf.gypi',
],
'include_dirs': [
- '../include/private',
'../src/core', # needed to get SkGlyphCache.h and SkTextFormatParams.h
'../src/pdf',
'../src/utils', # needed to get SkBitSet.h
'../include/effects',
'../include/images',
'../include/ports',
- '../include/private',
'../include/utils',
'../include/utils/win',
'../src/core',
'xml.gyp:*',
],
'include_dirs': [
- '../include/private',
'../include/svg',
'../src/core',
],
'../tools/skpinfo.cpp',
],
'include_dirs': [
- '../include/private',
'../src/core/',
],
'dependencies': [
'../tools/LazyDecodeBitmap.cpp',
],
'include_dirs': [
- '../include/private',
'../src/core/',
'../src/images',
'../src/lazy',
'target_name': 'filter',
'type': 'executable',
'include_dirs' : [
- '../include/private',
'../src/core',
'../src/utils/debugger',
],
'../include/images',
'../include/pathops',
'../include/pipe',
- '../include/private',
'../include/utils',
'../include/utils/mac',
'../include/utils/unix',
'<(skia_src_path)/utils/SkThreadUtils_win.cpp',
'<(skia_src_path)/utils/SkThreadUtils_win.h',
'<(skia_src_path)/utils/SkTFitsIn.h',
+ '<(skia_src_path)/utils/SkTLogic.h',
#mac
'<(skia_include_path)/utils/mac/SkCGUtils.h',
'xml.gyp:xml',
],
'include_dirs': [
- '../include/private',
'../include/views',
'../include/views/unix',
'../src/gpu',
'include_dirs' : [
'../bench',
'../include/gpu',
- '../include/private',
'../src/core',
'../src/effects',
'../src/images',
'dependencies': [
'etc1.gyp:libetc1',
'flags.gyp:flags',
- 'gputest.gyp:skgputest',
+ 'gputest.gyp:skgputest',
'skia_lib.gyp:skia_lib',
'tools.gyp:proc_stats',
'tools.gyp:sk_tool_utils',
'-lGLESv2',
'-lEGL',
],
- },
+ },
}],
],
},
'skia_lib.gyp:skia_lib',
],
'include_dirs': [
- '../include/private',
'../include/device/xps',
'../include/utils/win',
'../src/core', # needed to get SkGlyphCache.h
#ifndef SkPictureRecorder_DEFINED
#define SkPictureRecorder_DEFINED
-#include "../private/SkMiniRecorder.h"
+#include "../../src/core/SkMiniRecorder.h"
#include "SkBBHFactory.h"
#include "SkPicture.h"
#include "SkRefCnt.h"
*/
#include "GrTypes.h"
-#include "../private/SkTLogic.h"
+#include "../../src/utils/SkTLogic.h"
#ifndef GrBlend_DEFINED
#define GrBlend_DEFINED
#define SkGLContext_DEFINED
#include "GrGLInterface.h"
-#include "../../private/SkGpuFenceSync.h"
+#include "../../src/gpu/SkGpuFenceSync.h"
/**
* Create an offscreen opengl context with an RGBA8 / 8bit stencil FBO.
class SK_API SkGLContext : public SkRefCnt {
public:
-
+
~SkGLContext() override;
#define SkOSWindow_Win_DEFINED
#include "SkWindow.h"
-#include "../private/SkFunction.h"
-#include "../private/SkTHash.h"
+#include "../../src/core/SkFunction.h"
+#include "../../src/core/SkTHash.h"
#if SK_ANGLE
#include "EGL/egl.h"