fix ugly access-after-free bug when doing asyncronous NS lookups

git-svn-id: file:///home/lennart/svn/public/pulseaudio/trunk@1004 fefdeb5f-60dc-0310-8127-8f9354f1896f

diff --git a/src/polypcore/socket-client.c b/src/polypcore/socket-client.c
index fd840ab..efb6de9 100644 (file)
--- a/src/polypcore/socket-client.c
+++ b/src/polypcore/socket-client.c
@@ -376,16 +376,18 @@ static void asyncns_cb(pa_mainloop_api*m, pa_io_event *e, int fd, PA_GCC_UNUSED
     
     asyncns_freeaddrinfo(res);
 
-    goto finish;
-
+    m->io_free(c->asyncns_io_event);
+    c->asyncns_io_event = NULL;
+    return;
+    
 fail:
+    m->io_free(c->asyncns_io_event);
+    c->asyncns_io_event = NULL;
+    
     errno = EHOSTUNREACH;
     do_call(c);
+    return;
     
-finish:
-    
-    m->io_free(c->asyncns_io_event);
-    c->asyncns_io_event = NULL;
 }
 
 #endif