drm/msm: Use div64_ul instead of do_div
authorWan Jiabing <wanjiabing@vivo.com>
Tue, 26 Apr 2022 13:21:26 +0000 (21:21 +0800)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tue, 5 Jul 2022 03:01:11 +0000 (06:01 +0300)
Fix following coccicheck warning:
drivers/gpu/drm/msm/msm_gpu_devfreq.c:72:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.

Use div64_ul instead of do_div to avoid a possible truncation.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Patchwork: https://patchwork.freedesktop.org/patch/483499/
Link: https://lore.kernel.org/r/20220426132126.686447-1-wanjiabing@vivo.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/msm_gpu_devfreq.c

index d2539ca..c2ea978 100644 (file)
@@ -69,7 +69,7 @@ static void get_raw_dev_status(struct msm_gpu *gpu,
        df->time = time;
 
        busy_time *= USEC_PER_SEC;
-       do_div(busy_time, sample_rate);
+       busy_time = div64_ul(busy_time, sample_rate);
        if (WARN_ON(busy_time > ~0LU))
                busy_time = ~0LU;