MatchTableRecord::emit - fix boolean operator precedence warnings from PVS Studio...
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Sat, 2 Nov 2019 21:01:45 +0000 (21:01 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Sat, 2 Nov 2019 21:04:07 +0000 (21:04 +0000)
Make it clear that (Flags & MTRF_????) should resolve to a boolean.

llvm/utils/TableGen/GlobalISelEmitter.cpp

index ab4a91c..fdac5ba 100644 (file)
@@ -609,7 +609,7 @@ MatchTableRecord MatchTable::LineBreak = {
 void MatchTableRecord::emit(raw_ostream &OS, bool LineBreakIsNextAfterThis,
                             const MatchTable &Table) const {
   bool UseLineComment =
-      LineBreakIsNextAfterThis | (Flags & MTRF_LineBreakFollows);
+      LineBreakIsNextAfterThis || (Flags & MTRF_LineBreakFollows);
   if (Flags & (MTRF_JumpTarget | MTRF_CommaFollows))
     UseLineComment = false;
 
@@ -620,7 +620,7 @@ void MatchTableRecord::emit(raw_ostream &OS, bool LineBreakIsNextAfterThis,
   if (Flags & MTRF_Label)
     OS << ": @" << Table.getLabelIndex(LabelID);
 
-  if (Flags & MTRF_Comment && !UseLineComment)
+  if ((Flags & MTRF_Comment) && !UseLineComment)
     OS << "*/";
 
   if (Flags & MTRF_JumpTarget) {