pwm: mxs: Simplify using devm_pwmchip_add()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:28:12 +0000 (18:28 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:38:45 +0000 (21:38 +0200)
This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-mxs.c

index 558dc1d..766dbc5 100644 (file)
@@ -150,24 +150,15 @@ static int mxs_pwm_probe(struct platform_device *pdev)
        if (ret)
                return dev_err_probe(&pdev->dev, ret, "failed to reset PWM\n");
 
-       ret = pwmchip_add(&mxs->chip);
+       ret = devm_pwmchip_add(&pdev->dev, &mxs->chip);
        if (ret < 0) {
                dev_err(&pdev->dev, "failed to add pwm chip %d\n", ret);
                return ret;
        }
 
-       platform_set_drvdata(pdev, mxs);
-
        return 0;
 }
 
-static int mxs_pwm_remove(struct platform_device *pdev)
-{
-       struct mxs_pwm_chip *mxs = platform_get_drvdata(pdev);
-
-       return pwmchip_remove(&mxs->chip);
-}
-
 static const struct of_device_id mxs_pwm_dt_ids[] = {
        { .compatible = "fsl,imx23-pwm", },
        { /* sentinel */ }
@@ -180,7 +171,6 @@ static struct platform_driver mxs_pwm_driver = {
                .of_match_table = mxs_pwm_dt_ids,
        },
        .probe = mxs_pwm_probe,
-       .remove = mxs_pwm_remove,
 };
 module_platform_driver(mxs_pwm_driver);