drm/i915: Introduce HAS_SAGV()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 31 Jan 2023 00:21:25 +0000 (02:21 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 1 Feb 2023 20:06:07 +0000 (22:06 +0200)
Introuce a HAS_SAGV() macro to answer the question whether
the platform in general supports SAGV. intel_has_sagv() will
keep on giving us the more specific answer whether the current
device supports SAGV or not.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230131002127.29305-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/skl_watermark.c
drivers/gpu/drm/i915/i915_drv.h

index 0c60503..5916694 100644 (file)
@@ -64,7 +64,7 @@ static bool skl_needs_memory_bw_wa(struct drm_i915_private *i915)
 static bool
 intel_has_sagv(struct drm_i915_private *i915)
 {
-       return DISPLAY_VER(i915) >= 9 && !IS_LP(i915) &&
+       return HAS_SAGV(i915) &&
                i915->display.sagv.status != I915_SAGV_NOT_CONTROLLED;
 }
 
@@ -92,7 +92,7 @@ intel_sagv_block_time(struct drm_i915_private *i915)
                return val;
        } else if (DISPLAY_VER(i915) == 11) {
                return 10;
-       } else if (DISPLAY_VER(i915) == 9 && !IS_LP(i915)) {
+       } else if (HAS_SAGV(i915)) {
                return 30;
        } else {
                return 0;
@@ -101,7 +101,7 @@ intel_sagv_block_time(struct drm_i915_private *i915)
 
 static void intel_sagv_init(struct drm_i915_private *i915)
 {
-       if (!intel_has_sagv(i915))
+       if (!HAS_SAGV(i915))
                i915->display.sagv.status = I915_SAGV_NOT_CONTROLLED;
 
        /*
index 495788e..45be91d 100644 (file)
@@ -859,7 +859,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
  */
 #define HAS_64K_PAGES(dev_priv) (INTEL_INFO(dev_priv)->has_64k_pages)
 
-#define HAS_IPC(dev_priv)               (INTEL_INFO(dev_priv)->display.has_ipc)
+#define HAS_IPC(dev_priv)              (INTEL_INFO(dev_priv)->display.has_ipc)
+#define HAS_SAGV(dev_priv)             (DISPLAY_VER(dev_priv) >= 9 && !IS_LP(dev_priv))
 
 #define HAS_REGION(i915, i) (RUNTIME_INFO(i915)->memory_regions & (i))
 #define HAS_LMEM(i915) HAS_REGION(i915, REGION_LMEM)