projects / platform / core / csapi / tizenfx.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 4c6d614)
Add EditorBrowsableState.Never attribute at public members (#2673)
authorjeremy-jang <35089715+jeremy-jang@users.noreply.github.com>
Tue, 23 Feb 2021 04:38:45 +0000 (13:38 +0900)
committerGitHub <noreply@github.com>
Tue, 23 Feb 2021 04:38:45 +0000 (13:38 +0900)
* [ThemeManager] Add an attribute at public members

Add EditorBrowsableState.Never attribute at public members to hide
members from editor.

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
* [ThemeManager] Remove unused using statements

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
* [ThemeManager] Move to src/ from internals/src

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Co-authored-by: pjh9216 <jh9216.park@samsung.com>
src/Tizen.Applications.ThemeManager/Interop/Interop.Libraries.cs [moved from internals/src/Tizen.Applications.ThemeManager/Interop/Interop.Libraries.cs with 100% similarity] patch | blob | history
src/Tizen.Applications.ThemeManager/Interop/Interop.ThemeManager.cs [moved from internals/src/Tizen.Applications.ThemeManager/Interop/Interop.ThemeManager.cs with 100% similarity] patch | blob | history
src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj [moved from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj with 58% similarity] patch | blob | history
src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln [moved from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln with 52% similarity] patch | blob | history
src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs [moved from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs with 93% similarity] patch | blob | history
src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs [moved from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs with 89% similarity] patch | blob | history
src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs [moved from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs with 95% similarity] patch | blob | history

diff --git a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj
similarity index 58%
rename from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj
rename to src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj
index 4111fa5..974ea0f 100755 (executable)
--- a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj
+++ b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.csproj
@@ -5,7 +5,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\..\src\Tizen\Tizen.csproj" />
+    <ProjectReference Include="..\Tizen\Tizen.csproj" />
+    <ProjectReference Include="..\Tizen.Log\Tizen.Log.csproj" />
   </ItemGroup>
 
 
diff --git a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln
similarity index 52%
rename from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln
rename to src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln
index b059d91..609654b 100755 (executable)
--- a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln
+++ b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager.sln
@@ -4,11 +4,10 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 VisualStudioVersion = 16.0.29806.167
 MinimumVisualStudioVersion = 15.0.26124.0
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tizen.Applications.ThemeManager", "Tizen.Applications.ThemeManager.csproj", "{C37063A6-0105-43F6-B3EA-CA4786F62BD7}"
-       ProjectSection(ProjectDependencies) = postProject
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3} = {A0671F32-9031-4F70-B888-D3A27ABC05F3}
-       EndProjectSection
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tizen", "..\..\..\src\Tizen\Tizen.csproj", "{A0671F32-9031-4F70-B888-D3A27ABC05F3}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tizen", "..\Tizen\Tizen.csproj", "{1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}"
+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tizen.Log", "..\Tizen.Log\Tizen.Log.csproj", "{116E46A3-8384-4AC8-9175-31D05BCF1F03}"
 EndProject
 Global
        GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -32,18 +31,30 @@ Global
                {C37063A6-0105-43F6-B3EA-CA4786F62BD7}.Release|x64.Build.0 = Release|Any CPU
                {C37063A6-0105-43F6-B3EA-CA4786F62BD7}.Release|x86.ActiveCfg = Release|Any CPU
                {C37063A6-0105-43F6-B3EA-CA4786F62BD7}.Release|x86.Build.0 = Release|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Debug|Any CPU.Build.0 = Debug|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Debug|x64.ActiveCfg = Debug|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Debug|x64.Build.0 = Debug|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Debug|x86.ActiveCfg = Debug|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Debug|x86.Build.0 = Debug|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Release|Any CPU.ActiveCfg = Release|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Release|Any CPU.Build.0 = Release|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Release|x64.ActiveCfg = Release|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Release|x64.Build.0 = Release|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Release|x86.ActiveCfg = Release|Any CPU
-               {A0671F32-9031-4F70-B888-D3A27ABC05F3}.Release|x86.Build.0 = Release|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Debug|Any CPU.Build.0 = Debug|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Debug|x64.ActiveCfg = Debug|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Debug|x64.Build.0 = Debug|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Debug|x86.ActiveCfg = Debug|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Debug|x86.Build.0 = Debug|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Release|Any CPU.ActiveCfg = Release|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Release|Any CPU.Build.0 = Release|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Release|x64.ActiveCfg = Release|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Release|x64.Build.0 = Release|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Release|x86.ActiveCfg = Release|Any CPU
+               {1ED3BEBF-B675-45E3-8ABE-76A87A04A5FE}.Release|x86.Build.0 = Release|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Debug|Any CPU.Build.0 = Debug|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Debug|x64.ActiveCfg = Debug|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Debug|x64.Build.0 = Debug|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Debug|x86.ActiveCfg = Debug|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Debug|x86.Build.0 = Debug|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Release|Any CPU.ActiveCfg = Release|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Release|Any CPU.Build.0 = Release|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Release|x64.ActiveCfg = Release|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Release|x64.Build.0 = Release|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Release|x86.ActiveCfg = Release|Any CPU
+               {116E46A3-8384-4AC8-9175-31D05BCF1F03}.Release|x86.Build.0 = Release|Any CPU
        EndGlobalSection
        GlobalSection(SolutionProperties) = preSolution
                HideSolutionNode = FALSE
diff --git a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs
similarity index 93%
rename from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs
rename to src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs
index 0e52b0e..f64775d 100755 (executable)
--- a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs
+++ b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/Theme.cs
@@ -15,8 +15,8 @@
  */
 
 using System;
-using System.Collections;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Runtime.InteropServices;
 
 namespace Tizen.Applications.ThemeManager
@@ -25,6 +25,7 @@ namespace Tizen.Applications.ThemeManager
     /// 
     /// </summary>
     /// <since_tizen> 8 </since_tizen>
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public class Theme : IDisposable
     {
         private bool _disposed = false;
@@ -45,6 +46,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="InvalidOperationException">Thrown when failed because of system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public Theme(Theme theme)
         {
             if (theme == null || theme._handle == IntPtr.Zero)
@@ -111,42 +113,49 @@ namespace Tizen.Applications.ThemeManager
         /// A Theme ID
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string Id { get { return _id; } }
 
         /// <summary>
         /// A Theme Version
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string Version { get { return _version; } }
 
         /// <summary>
         /// A Theme ToolVersion
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string ToolVersion { get { return _toolVersion; } }
 
         /// <summary>
         /// A Theme Title
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string Title { get { return _title; } }
 
         /// <summary>
         /// A Theme Resolution
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string Resolution { get { return _resolution; } }
 
         /// <summary>
         /// A Theme Preview
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string Preview { get { return _preview; } }
 
         /// <summary>
         /// A Theme Description
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string Description { get { return _description; } }
 
 
@@ -158,6 +167,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string GetString(string key)
         {
             string str;
@@ -178,6 +188,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public IEnumerable<string> GetStrings(string key)
         {
             IntPtr val;
@@ -201,6 +212,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public int GetInt(string key)
         {
             int val;
@@ -221,6 +233,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public float GetFloat(string key)
         {
             float val;
@@ -241,6 +254,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public bool GetBool(string key)
         {
             bool val;
@@ -261,6 +275,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string GetPath(string key)
         {
             string val;
@@ -281,6 +296,7 @@ namespace Tizen.Applications.ThemeManager
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="InvalidOperationException">Thrown when failed because of the system error.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public IEnumerable<string> GetPaths(string key)
         {
             IntPtr val;
@@ -313,6 +329,7 @@ namespace Tizen.Applications.ThemeManager
         /// <param name="key">The string key to find information.</param>
         /// <since_tizen> 9 </since_tizen>
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public bool HasKey(string key)
         {
             bool val;
@@ -329,6 +346,7 @@ namespace Tizen.Applications.ThemeManager
         /// Releases all resources used by the Theme class.
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public void Dispose()
         {
             Dispose(true);
diff --git a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs
similarity index 89%
rename from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs
rename to src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs
index 67a753c..dcaaff7 100755 (executable)
--- a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs
+++ b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeEventArgs.cs
@@ -15,8 +15,7 @@
  */
 
 using System;
-using System.Collections.Generic;
-using System.Text;
+using System.ComponentModel;
 
 namespace Tizen.Applications.ThemeManager
 {
@@ -24,6 +23,7 @@ namespace Tizen.Applications.ThemeManager
     /// ThemeEventArgs class. This class is an event arguments of the ThemeLoaderChanged events.
     /// </summary>
     /// <since_tizen> 8 </since_tizen>
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public class ThemeEventArgs : EventArgs
     {
         internal ThemeEventArgs(Theme theme)
@@ -35,6 +35,7 @@ namespace Tizen.Applications.ThemeManager
         /// A Theme
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public Theme Theme { get; }
     }
 }
diff --git a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs
similarity index 95%
rename from internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs
rename to src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs
index 274f799..808fb81 100755 (executable)
--- a/internals/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs
+++ b/src/Tizen.Applications.ThemeManager/Tizen.Applications.ThemeManager/ThemeLoader.cs
@@ -16,6 +16,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Runtime.InteropServices;
 
 namespace Tizen.Applications.ThemeManager
@@ -24,6 +25,7 @@ namespace Tizen.Applications.ThemeManager
     /// 
     /// </summary>
     /// <since_tizen> 8 </since_tizen>
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public class ThemeLoader : IDisposable
     {
         private const string LogTag = "Tizen.Applications.ThemeManager";
@@ -39,6 +41,7 @@ namespace Tizen.Applications.ThemeManager
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
         /// <exception cref="OutOfMemoryException">Failed to create handle.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public ThemeLoader()
         {
             Interop.ThemeManager.ErrorCode err = Interop.ThemeManager.LoaderCreate(out _loaderHandle);
@@ -60,6 +63,7 @@ namespace Tizen.Applications.ThemeManager
         /// <since_tizen> 8 </since_tizen>
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public event EventHandler<ThemeEventArgs> ThemeChanged
         {
             add
@@ -100,6 +104,7 @@ namespace Tizen.Applications.ThemeManager
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public Theme CurrentTheme
         {
             get
@@ -138,6 +143,7 @@ namespace Tizen.Applications.ThemeManager
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public Theme LoadTheme(string id)
         {
             IntPtr _themeHandle;
@@ -157,6 +163,7 @@ namespace Tizen.Applications.ThemeManager
         /// <since_tizen> 8 </since_tizen>
         /// <exception cref="ArgumentException">Thrown when failed because of an invalid argument.</exception>
         /// <exception cref="OutOfMemoryException">Thrown when failed because of out of memory.</exception>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public IEnumerable<string> QueryIds()
         {
             IntPtr ids;
@@ -188,6 +195,7 @@ namespace Tizen.Applications.ThemeManager
         /// Releases all resources used by the ThemeLoader class.
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public void Dispose()
         {
             Dispose(true);
Domain: Dotnet / Frameworks;