ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config()
authorDamien Le Moal <dlemoal@kernel.org>
Sun, 4 Jun 2023 23:27:14 +0000 (08:27 +0900)
committerDamien Le Moal <dlemoal@kernel.org>
Mon, 5 Jun 2023 13:03:28 +0000 (22:03 +0900)
In ata_scsi_dev_config(), instead of hard-coding the test to check if
an ATA device supports NCQ by looking at the ATA_DFLAG_NCQ flag, use
ata_ncq_supported().

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
drivers/ata/libata-scsi.c

index 7bb12de..9e79998 100644 (file)
@@ -1122,7 +1122,7 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev)
        if (dev->flags & ATA_DFLAG_AN)
                set_bit(SDEV_EVT_MEDIA_CHANGE, sdev->supported_events);
 
-       if (dev->flags & ATA_DFLAG_NCQ)
+       if (ata_ncq_supported(dev))
                depth = min(sdev->host->can_queue, ata_id_queue_depth(dev->id));
        depth = min(ATA_MAX_QUEUE, depth);
        scsi_change_queue_depth(sdev, depth);