journal: warn when we fail to append a tag to a journal
authorFranck Bui <fbui@suse.com>
Fri, 23 Sep 2016 10:12:13 +0000 (12:12 +0200)
committerFranck Bui <fbui@suse.com>
Fri, 23 Sep 2016 12:59:00 +0000 (14:59 +0200)
We shouldn't silently fail when appending the tag to a journal file
since FSS protection will simply be disabled in this case.

src/journal/journal-file.c

index 7504326..f6f58a1 100644 (file)
@@ -333,8 +333,13 @@ JournalFile* journal_file_close(JournalFile *f) {
 
 #ifdef HAVE_GCRYPT
         /* Write the final tag */
-        if (f->seal && f->writable)
-                journal_file_append_tag(f);
+        if (f->seal && f->writable) {
+                int r;
+
+                r = journal_file_append_tag(f);
+                if (r < 0)
+                        log_error_errno(r, "Failed to append tag when closing journal: %m");
+        }
 #endif
 
         if (f->post_change_timer) {