scripts: kernel-doc: Relink argument parsing error handling to pod2usage
authorTomasz Warniełło <tomasz.warniello@gmail.com>
Fri, 18 Feb 2022 18:16:19 +0000 (19:16 +0100)
committerJonathan Corbet <corbet@lwn.net>
Thu, 24 Feb 2022 17:52:45 +0000 (10:52 -0700)
The former usage function is substituted, although not as the -h and -help
parameter handler yet.

Purpose: Use Pod::Usage to handle documentation printing in an integrated
way.

Signed-off-by: Tomasz Warniełło <tomasz.warniello@gmail.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Disliked-by: Akira Yokosawa <akiyks@gmail.com>
Link: https://lore.kernel.org/r/20220218181628.1411551-3-tomasz.warniello@gmail.com
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
scripts/kernel-doc

index c8fbf1d..e7f7251 100755 (executable)
@@ -16,6 +16,8 @@ use strict;
 ## This software falls under the GNU General Public License.     ##
 ## Please read the COPYING file for more information             ##
 
+use Pod::Usage qw/pod2usage/;
+
 =head1 NAME
 
 kernel-doc - Print formatted kernel documentation to stdout
@@ -298,7 +300,13 @@ my $blankline_rst = "\n";
 
 # read arguments
 if ($#ARGV == -1) {
-    usage();
+       pod2usage(
+               -message => "No arguments!\n",
+               -exitval => 1,
+               -verbose => 99,
+               -sections => 'SYNOPSIS',
+               -output => \*STDERR,
+       );
 }
 
 my $kernelversion;
@@ -518,8 +526,14 @@ while ($ARGV[0] =~ m/^--?(.*)/) {
            die "Sphinx version should either major.minor or major.minor.patch format\n";
        }
     } else {
-       # Unknown argument
-        usage();
+               # Unknown argument
+               pod2usage(
+                       -message => "Argument unknown!\n",
+                       -exitval => 1,
+                       -verbose => 99,
+                       -sections => 'SYNOPSIS',
+                       -output => \*STDERR,
+               );
     }
 }