RDMA/core: Use dev_err/dbg/etc instead of pr_* + ibdev->name

Any messages related to a device should be printed with the dev_*
formatters. This provides greater consistency for the user.

The core does not set pr_fmt so this has no significant change.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
index 8957d31..ebc6441 100644 (file)
--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -212,9 +212,8 @@ static void free_gid_entry_locked(struct ib_gid_table_entry *entry)
        u8 port_num = entry->attr.port_num;
        struct ib_gid_table *table = rdma_gid_table(device, port_num);
 
-       pr_debug("%s device=%s port=%d index=%d gid %pI6\n", __func__,
-                device->name, port_num, entry->attr.index,
-                entry->attr.gid.raw);
+       dev_dbg(&device->dev, "%s port=%d index=%d gid %pI6\n", __func__,
+               port_num, entry->attr.index, entry->attr.gid.raw);
 
        if (rdma_cap_roce_gid_table(device, port_num) &&
            entry->state != GID_TABLE_ENTRY_INVALID)
@@ -289,9 +288,9 @@ static void store_gid_entry(struct ib_gid_table *table,
 {
        entry->state = GID_TABLE_ENTRY_VALID;
 
-       pr_debug("%s device=%s port=%d index=%d gid %pI6\n", __func__,
-                entry->attr.device->name, entry->attr.port_num,
-                entry->attr.index, entry->attr.gid.raw);
+       dev_dbg(&entry->attr.device->dev, "%s port=%d index=%d gid %pI6\n",
+               __func__, entry->attr.port_num, entry->attr.index,
+               entry->attr.gid.raw);
 
        lockdep_assert_held(&table->lock);
        write_lock_irq(&table->rwlock);
@@ -320,17 +319,16 @@ static int add_roce_gid(struct ib_gid_table_entry *entry)
        int ret;
 
        if (!attr->ndev) {
-               pr_err("%s NULL netdev device=%s port=%d index=%d\n",
-                      __func__, attr->device->name, attr->port_num,
-                      attr->index);
+               dev_err(&attr->device->dev, "%s NULL netdev port=%d index=%d\n",
+                       __func__, attr->port_num, attr->index);
                return -EINVAL;
        }
        if (rdma_cap_roce_gid_table(attr->device, attr->port_num)) {
                ret = attr->device->add_gid(attr, &entry->context);
                if (ret) {
-                       pr_err("%s GID add failed device=%s port=%d index=%d\n",
-                              __func__, attr->device->name, attr->port_num,
-                              attr->index);
+                       dev_err(&attr->device->dev,
+                               "%s GID add failed port=%d index=%d\n",
+                               __func__, attr->port_num, attr->index);
                        return ret;
                }
        }
@@ -402,9 +400,8 @@ static void del_gid(struct ib_device *ib_dev, u8 port,
 
        lockdep_assert_held(&table->lock);
 
-       pr_debug("%s device=%s port=%d index=%d gid %pI6\n", __func__,
-                ib_dev->name, port, ix,
-                table->data_vec[ix]->attr.gid.raw);
+       dev_dbg(&ib_dev->dev, "%s port=%d index=%d gid %pI6\n", __func__, port,
+               ix, table->data_vec[ix]->attr.gid.raw);
 
        write_lock_irq(&table->rwlock);
        entry = table->data_vec[ix];
@@ -782,9 +779,9 @@ static void release_gid_table(struct ib_device *device, u8 port,
                if (is_gid_entry_free(table->data_vec[i]))
                        continue;
                if (kref_read(&table->data_vec[i]->kref) > 1) {
-                       pr_err("GID entry ref leak for %s (index %d) ref=%d\n",
-                              device->name, i,
-                              kref_read(&table->data_vec[i]->kref));
+                       dev_err(&device->dev,
+                               "GID entry ref leak for index %d ref=%d\n", i,
+                               kref_read(&table->data_vec[i]->kref));
                        leak = true;
                }
        }
@@ -1303,8 +1300,9 @@ static int config_non_roce_gid_cache(struct ib_device *device,
                        continue;
                ret = device->query_gid(device, port, i, &gid_attr.gid);
                if (ret) {
-                       pr_warn("query_gid failed (%d) for %s (index %d)\n",
-                               ret, device->name, i);
+                       dev_warn(&device->dev,
+                                "query_gid failed (%d) for index %d\n", ret,
+                                i);
                        goto err;
                }
                gid_attr.index = i;
@@ -1333,8 +1331,7 @@ static void ib_cache_update(struct ib_device *device,
 
        ret = ib_query_port(device, port, tprops);
        if (ret) {
-               pr_warn("ib_query_port failed (%d) for %s\n",
-                       ret, device->name);
+               dev_warn(&device->dev, "ib_query_port failed (%d)\n", ret);
                goto err;
        }
 
@@ -1356,8 +1353,9 @@ static void ib_cache_update(struct ib_device *device,
        for (i = 0; i < pkey_cache->table_len; ++i) {
                ret = ib_query_pkey(device, port, i, pkey_cache->table + i);
                if (ret) {
-                       pr_warn("ib_query_pkey failed (%d) for %s (index %d)\n",
-                               ret, device->name, i);
+                       dev_warn(&device->dev,
+                                "ib_query_pkey failed (%d) for index %d\n",
+                                ret, i);
                        goto err;
                }
        }

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index a57c8b8..c650223 100644 (file)
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2352,8 +2352,8 @@ static void cma_listen_on_dev(struct rdma_id_private *id_priv,
 
        ret = rdma_listen(id, id_priv->backlog);
        if (ret)
-               pr_warn("RDMA CMA: cma_listen_on_dev, error %d, listening on device %s\n",
-                       ret, cma_dev->device->name);
+               dev_warn(&cma_dev->device->dev,
+                        "RDMA CMA: cma_listen_on_dev, error %d\n", ret);
 }
 
 static void cma_listen_on_all(struct rdma_id_private *id_priv)
@@ -4082,9 +4082,10 @@ static int cma_join_ib_multicast(struct rdma_id_private *id_priv,
            (!ib_sa_sendonly_fullmem_support(&sa_client,
                                             id_priv->id.device,
                                             id_priv->id.port_num))) {
-               pr_warn("RDMA CM: %s port %u Unable to multicast join\n"
-                       "RDMA CM: SM doesn't support Send Only Full Member option\n",
-                       id_priv->id.device->name, id_priv->id.port_num);
+               dev_warn(
+                       &id_priv->id.device->dev,
+                       "RDMA CM: port %u Unable to multicast join: SM doesn't support Send Only Full Member option\n",
+                       id_priv->id.port_num);
                return -EOPNOTSUPP;
        }
 

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index faacf95..7c3ff43 100644 (file)
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -123,8 +123,9 @@ static int ib_device_check_mandatory(struct ib_device *device)
 
        for (i = 0; i < ARRAY_SIZE(mandatory_table); ++i) {
                if (!*(void **) ((void *) device + mandatory_table[i].offset)) {
-                       pr_warn("Device %s is missing mandatory function %s\n",
-                               device->name, mandatory_table[i].name);
+                       dev_warn(&device->dev,
+                                "Device is missing mandatory function %s\n",
+                                mandatory_table[i].name);
                        return -EINVAL;
                }
        }
@@ -513,20 +514,21 @@ int ib_register_device(struct ib_device *device, const char *name,
 
        ret = read_port_immutable(device);
        if (ret) {
-               pr_warn("Couldn't create per port immutable data %s\n",
-                       device->name);
+               dev_warn(&device->dev,
+                        "Couldn't create per port immutable data\n");
                goto out;
        }
 
        ret = setup_port_pkey_list(device);
        if (ret) {
-               pr_warn("Couldn't create per port_pkey_list\n");
+               dev_warn(&device->dev, "Couldn't create per port_pkey_list\n");
                goto out;
        }
 
        ret = ib_cache_setup_one(device);
        if (ret) {
-               pr_warn("Couldn't set up InfiniBand P_Key/GID cache\n");
+               dev_warn(&device->dev,
+                        "Couldn't set up InfiniBand P_Key/GID cache\n");
                goto port_cleanup;
        }
 
@@ -534,21 +536,23 @@ int ib_register_device(struct ib_device *device, const char *name,
 
        ret = ib_device_register_rdmacg(device);
        if (ret) {
-               pr_warn("Couldn't register device with rdma cgroup\n");
+               dev_warn(&device->dev,
+                        "Couldn't register device with rdma cgroup\n");
                goto cache_cleanup;
        }
 
        memset(&device->attrs, 0, sizeof(device->attrs));
        ret = device->query_device(device, &device->attrs, &uhw);
        if (ret) {
-               pr_warn("Couldn't query the device attributes\n");
+               dev_warn(&device->dev,
+                        "Couldn't query the device attributes\n");
                goto cg_cleanup;
        }
 
        ret = ib_device_register_sysfs(device, port_callback);
        if (ret) {
-               pr_warn("Couldn't register device %s with driver model\n",
-                       device->name);
+               dev_warn(&device->dev,
+                        "Couldn't register device with driver model\n");
                goto cg_cleanup;
        }
 
@@ -699,8 +703,9 @@ void ib_unregister_client(struct ib_client *client)
                                               found_context->data : NULL);
 
                if (!found_context) {
-                       pr_warn("No client context found for %s/%s\n",
-                               device->name, client->name);
+                       dev_warn(&device->dev,
+                                "No client context found for %s\n",
+                                client->name);
                        continue;
                }
 
@@ -764,8 +769,8 @@ void ib_set_client_data(struct ib_device *device, struct ib_client *client,
                        goto out;
                }
 
-       pr_warn("No client context found for %s/%s\n",
-               device->name, client->name);
+       dev_warn(&device->dev, "No client context found for %s\n",
+                client->name);
 
 out:
        write_unlock_irqrestore(&device->client_data_lock, flags);

diff --git a/drivers/infiniband/core/fmr_pool.c b/drivers/infiniband/core/fmr_pool.c
index a077500..d1f2eee 100644 (file)
--- a/drivers/infiniband/core/fmr_pool.c
+++ b/drivers/infiniband/core/fmr_pool.c
@@ -213,7 +213,7 @@ struct ib_fmr_pool *ib_create_fmr_pool(struct ib_pd             *pd,
        device = pd->device;
        if (!device->alloc_fmr    || !device->dealloc_fmr  ||
            !device->map_phys_fmr || !device->unmap_fmr) {
-               pr_info(PFX "Device %s does not support FMRs\n", device->name);
+               dev_info(&device->dev, "Device does not support FMRs\n");
                return ERR_PTR(-ENOSYS);
        }
 

diff --git a/drivers/infiniband/core/restrack.c b/drivers/infiniband/core/restrack.c
index 3b7fa0c..bcc693f 100644 (file)
--- a/drivers/infiniband/core/restrack.c
+++ b/drivers/infiniband/core/restrack.c
@@ -50,8 +50,7 @@ void rdma_restrack_clean(struct rdma_restrack_root *res)
 
        dev = container_of(res, struct ib_device, res);
        pr_err("restrack: %s", CUT_HERE);
-       pr_err("restrack: BUG: RESTRACK detected leak of resources on %s\n",
-              dev->name);
+       dev_err(&dev->dev, "BUG: RESTRACK detected leak of resources\n");
        hash_for_each(res->hash, bkt, e, node) {
                if (rdma_is_kernel_res(e)) {
                        owner = e->kern_name;

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index c36be38..ee5fc84 100644 (file)
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1629,14 +1629,16 @@ static int _ib_modify_qp(struct ib_qp *qp, struct ib_qp_attr *attr,
 
        if (rdma_ib_or_roce(qp->device, port)) {
                if (attr_mask & IB_QP_RQ_PSN && attr->rq_psn & ~0xffffff) {
-                       pr_warn("%s: %s rq_psn overflow, masking to 24 bits\n",
-                               __func__, qp->device->name);
+                       dev_warn(&qp->device->dev,
+                                "%s rq_psn overflow, masking to 24 bits\n",
+                                __func__);
                        attr->rq_psn &= 0xffffff;
                }
 
                if (attr_mask & IB_QP_SQ_PSN && attr->sq_psn & ~0xffffff) {
-                       pr_warn("%s: %s sq_psn overflow, masking to 24 bits\n",
-                               __func__, qp->device->name);
+                       dev_warn(&qp->device->dev,
+                                " %s sq_psn overflow, masking to 24 bits\n",
+                                __func__);
                        attr->sq_psn &= 0xffffff;
                }
        }