Fix a memory leak in QMetaObject::connectSlotsByName function.

QObjectPrivate::Connection time life should be controlled by
QMetaObject::Connection handle.

Change-Id: Ie7fcd950082a3e6cebc29ecc0622007470914edb
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>

diff --git a/src/corelib/kernel/qobject.cpp b/src/corelib/kernel/qobject.cpp
index 3a4d1da..b648432 100644 (file)
--- a/src/corelib/kernel/qobject.cpp
+++ b/src/corelib/kernel/qobject.cpp
@@ -3075,7 +3075,7 @@ void QMetaObject::connectSlotsByName(QObject *o)
             }
             if (sigIndex < 0)
                 continue;
-            if (QMetaObjectPrivate::connect(co, sigIndex, o, i)) {
+            if (Connection(QMetaObjectPrivate::connect(co, sigIndex, o, i))) {
                 foundIt = true;
                 break;
             }