projects
/
platform
/
kernel
/
linux-exynos.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d16c995
)
genirq: Fix potential memleak when failing to get irq pm
author
Shawn Lin
<shawn.lin@rock-chips.com>
Mon, 22 Aug 2016 08:21:52 +0000
(16:21 +0800)
committer
Thomas Gleixner
<tglx@linutronix.de>
Mon, 22 Aug 2016 09:22:44 +0000
(11:22 +0200)
Obviously we should free action here if irq_chip_pm_get failed.
Fixes:
be45beb2df69
: "genirq: Add runtime power management support for IRQ chips"
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link:
http://lkml.kernel.org/r/1471854112-13006-1-git-send-email-shawn.lin@rock-chips.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/manage.c
patch
|
blob
|
history
diff --git
a/kernel/irq/manage.c
b/kernel/irq/manage.c
index
73a2b78
..
9530fcd
100644
(file)
--- a/
kernel/irq/manage.c
+++ b/
kernel/irq/manage.c
@@
-1681,8
+1681,10
@@
int request_threaded_irq(unsigned int irq, irq_handler_t handler,
action->dev_id = dev_id;
retval = irq_chip_pm_get(&desc->irq_data);
- if (retval < 0)
+ if (retval < 0) {
+ kfree(action);
return retval;
+ }
chip_bus_lock(desc);
retval = __setup_irq(irq, desc, action);
@@
-1985,8
+1987,10
@@
int request_percpu_irq(unsigned int irq, irq_handler_t handler,
action->percpu_dev_id = dev_id;
retval = irq_chip_pm_get(&desc->irq_data);
- if (retval < 0)
+ if (retval < 0) {
+ kfree(action);
return retval;
+ }
chip_bus_lock(desc);
retval = __setup_irq(irq, desc, action);