leds: sc27xx: Fix return value check in sc27xx_led_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 22 May 2018 11:45:56 +0000 (11:45 +0000)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Tue, 22 May 2018 19:57:59 +0000 (21:57 +0200)
In case of error, the function dev_get_regmap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: e081c49e30ec ("leds: Add Spreadtrum SC27xx breathing light controller driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-sc27xx-bltc.c

index 54a90c8..9d9b7aa 100644 (file)
@@ -176,8 +176,8 @@ static int sc27xx_led_probe(struct platform_device *pdev)
        mutex_init(&priv->lock);
        priv->base = base;
        priv->regmap = dev_get_regmap(dev->parent, NULL);
-       if (IS_ERR(priv->regmap)) {
-               err = PTR_ERR(priv->regmap);
+       if (!priv->regmap) {
+               err = -ENODEV;
                dev_err(dev, "failed to get regmap: %d\n", err);
                return err;
        }