gst/gstquery.c (gst_query_new_convert): Spew if we try to convert a negative value...

Original commit message from CVS:
2005-08-24  Andy Wingo  <wingo@pobox.com>

* gst/gstquery.c (gst_query_new_convert): Spew if we try to
convert a negative value. Doesn't make much sense. Mostly this is
here to force callers to ensure -1 maps to -1.

diff --git a/ChangeLog b/ChangeLog
index 0e5e225b6c815be185ceb70a6dde290a7ed39cf4..f3f238a5298f6e0d69b9b3183db378f219b7690b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2005-08-24  Andy Wingo  <wingo@pobox.com>
+
+       * gst/gstquery.c (gst_query_new_convert): Spew if we try to
+       convert a negative value. Doesn't make much sense. Mostly this is
+       here to force callers to ensure -1 maps to -1.
+
 2005-08-24  Jan Schmidt  <thaytan@mad.scientist.com>
 
        * docs/pwg/advanced-types.xml:

diff --git a/gst/gstquery.c b/gst/gstquery.c
index ed66efccd732b63eb2772e211ccb8b2aa216abff..ff0867af360b33ef876fc6ac19df2e9a43ddb9a6 100644 (file)
--- a/gst/gstquery.c
+++ b/gst/gstquery.c
@@ -368,6 +368,8 @@ gst_query_new_convert (GstFormat src_fmt, gint64 value, GstFormat dest_fmt)
   GstQuery *query;
   GstStructure *structure;
 
+  g_return_val_if_fail (value >= 0, NULL);
+
   structure = gst_structure_new ("GstQueryConvert",
       "src_format", GST_TYPE_FORMAT, src_fmt,
       "src_value", G_TYPE_INT64, value,