Clarify logs related to coredump handling 77/234077/2
authorKarol Lewandowski <k.lewandowsk@samsung.com>
Thu, 21 May 2020 10:48:30 +0000 (12:48 +0200)
committerKarol Lewandowski <k.lewandowsk@samsung.com>
Thu, 21 May 2020 12:38:21 +0000 (14:38 +0200)
The coredump should not be created when minicoredumper (-s) works
correctly.  Make this clear in code and logs.

Change-Id: I2e4e160a46ac4be25143f310ffc336b121530cc8

src/crash-manager/crash-manager.c

index 42044be..bb01ee2 100644 (file)
@@ -702,12 +702,9 @@ static bool execute_minicoredump(struct crash_info *cinfo, int *exit_code)
        /* Minicoredumper must be executed to dump at least PRSTATUS for
           other tools, coredump, however, might have been disabled. */
        if (!config.dump_core && file_exists_in_dir(cinfo->pfx, coredump_name)) {
+               _E("Saving core disabled but coredump found (minicoredumper bug?). Removing coredump %s/%s", cinfo->pfx, coredump_name);
                if (!remove_file_in_dir(cinfo->pfx, coredump_name))
-                       _E("Saving core disabled - removing coredump %s/%s failed: %m",
-                          cinfo->pfx, coredump_name);
-               else
-                       _D("Saving core disabled - removed coredump %s/%s",
-                          cinfo->pfx, coredump_name);
+                       _E("Removing coredump %s/%s failed: %m", cinfo->pfx, coredump_name);
        }
 
 out: