fix undefined var backtrace issue.
authorZhang Qiang <qiang.z.zhang@intel.com>
Fri, 7 Sep 2012 05:12:45 +0000 (13:12 +0800)
committerZhang Qiang <qiang.z.zhang@intel.com>
Fri, 7 Sep 2012 05:57:59 +0000 (13:57 +0800)
Change-Id: I5d29c49a5f70e8fed1911992d0d4bae3095c96eb

gitbuildsys/runner.py

index 6e667c5..7ba98c2 100644 (file)
@@ -46,9 +46,7 @@ def runtool(cmdln_or_args, catch=1):
         cmd = shlex.split(cmdln_or_args)[0]
         shell = True
 
-    if catch != 3:
-        dev_null = os.open("/dev/null", os.O_WRONLY)
-
+    dev_null = os.open("/dev/null", os.O_WRONLY)
     sout = [dev_null, subprocess.PIPE, dev_null, subprocess.PIPE][catch]
     serr = [dev_null, dev_null, subprocess.PIPE, subprocess.STDOUT][catch]
 
@@ -65,8 +63,7 @@ def runtool(cmdln_or_args, catch=1):
         else:
             raise # relay
     finally:
-        if catch != 3:
-            os.close(dev_null)
+        os.close(dev_null)
 
     return (process.returncode, out)