fixup! Implement Fullscreen API

In tizen 2.4 environment, WRT calls the ewk_view_fullscreen_exit()
API and exits the event handler when pressing hardware back key
if it's fullscreen mode in only "Software key" mode or "windowed"
view mode.

However above two conditions(software key and windowed view modes)
were omitted in tizen 3.0, so the ewk_view_fullscreen_exit() API
was always called when pressing hardware back key in fullscreen mode.

This CL fixes these problem.

Bug: http://suprem.sec.samsung.net/jira/browse/TWF-3201

Change-Id: I4dda2d78be7af8cf75df72875aa2d7e94bbe2da9
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>

diff --git a/runtime/browser/web_application.cc b/runtime/browser/web_application.cc
index 5cb2b787d1dcfd1e1e49ebc0551d2bb29049567d..240df69a8c6c1c44b8eec476f47a2485f7027fcb 100755 (executable)
--- a/runtime/browser/web_application.cc
+++ b/runtime/browser/web_application.cc
@@ -978,6 +978,11 @@ void WebApplication::OnHardwareKey(WebView* view, const std::string& keyname) {
           RemoveWebViewFromStack(view_stack_.front());
         }
       }
+
+      if (app_data_->widget_info()->view_modes() == "fullscreen") {
+        ewk_view_fullscreen_exit(view->evas_object());
+        return;
+      }
     }
   } else if (enabled && kKeyNameMenu == keyname) {
     view->EvalJavascript(kMenuKeyEventScript);

diff --git a/runtime/browser/web_view_impl.cc b/runtime/browser/web_view_impl.cc
index 162bca963ed559cd64a0c5e3361cfc2c905f7a30..797f98e48c3b552c07fcc01d1e0ed08c1a741157 100644 (file)
--- a/runtime/browser/web_view_impl.cc
+++ b/runtime/browser/web_view_impl.cc
@@ -980,10 +980,6 @@ void WebViewImpl::OnRotation(int degree) {
 void WebViewImpl::OnKeyEvent(Eext_Callback_Type key_type) {
   std::string keyname;
   if (key_type == EEXT_CALLBACK_BACK) {
-    if (fullscreen_) {
-      ewk_view_fullscreen_exit(ewk_view_);
-      return;
-    }
     if (EINA_TRUE == ewk_view_text_selection_clear(ewk_view_)) {
       return;
     }