netfilter: nf_conntrack_broadcast: remove useless parameter
authorTaehee Yoo <ap420073@gmail.com>
Sun, 11 Feb 2018 14:28:18 +0000 (23:28 +0900)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 5 Mar 2018 22:15:43 +0000 (23:15 +0100)
parameter protoff in nf_conntrack_broadcast_help is not used anywhere.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/nf_conntrack_helper.h
net/netfilter/nf_conntrack_broadcast.c
net/netfilter/nf_conntrack_netbios_ns.c
net/netfilter/nf_conntrack_snmp.c

index fc39bba..32c2a94 100644 (file)
@@ -132,8 +132,7 @@ void nf_conntrack_helper_pernet_fini(struct net *net);
 int nf_conntrack_helper_init(void);
 void nf_conntrack_helper_fini(void);
 
-int nf_conntrack_broadcast_help(struct sk_buff *skb, unsigned int protoff,
-                               struct nf_conn *ct,
+int nf_conntrack_broadcast_help(struct sk_buff *skb, struct nf_conn *ct,
                                enum ip_conntrack_info ctinfo,
                                unsigned int timeout);
 
index ecc3ab7..a1086bd 100644 (file)
@@ -20,7 +20,6 @@
 #include <net/netfilter/nf_conntrack_expect.h>
 
 int nf_conntrack_broadcast_help(struct sk_buff *skb,
-                               unsigned int protoff,
                                struct nf_conn *ct,
                                enum ip_conntrack_info ctinfo,
                                unsigned int timeout)
index 496ce17..a4a59dc 100644 (file)
@@ -41,9 +41,10 @@ static struct nf_conntrack_expect_policy exp_policy = {
 };
 
 static int netbios_ns_help(struct sk_buff *skb, unsigned int protoff,
-                  struct nf_conn *ct, enum ip_conntrack_info ctinfo)
+                          struct nf_conn *ct,
+                          enum ip_conntrack_info ctinfo)
 {
-       return nf_conntrack_broadcast_help(skb, protoff, ct, ctinfo, timeout);
+       return nf_conntrack_broadcast_help(skb, ct, ctinfo, timeout);
 }
 
 static struct nf_conntrack_helper helper __read_mostly = {
index 87b95a2..2d0f8e0 100644 (file)
@@ -36,11 +36,12 @@ int (*nf_nat_snmp_hook)(struct sk_buff *skb,
 EXPORT_SYMBOL_GPL(nf_nat_snmp_hook);
 
 static int snmp_conntrack_help(struct sk_buff *skb, unsigned int protoff,
-               struct nf_conn *ct, enum ip_conntrack_info ctinfo)
+                              struct nf_conn *ct,
+                              enum ip_conntrack_info ctinfo)
 {
        typeof(nf_nat_snmp_hook) nf_nat_snmp;
 
-       nf_conntrack_broadcast_help(skb, protoff, ct, ctinfo, timeout);
+       nf_conntrack_broadcast_help(skb, ct, ctinfo, timeout);
 
        nf_nat_snmp = rcu_dereference(nf_nat_snmp_hook);
        if (nf_nat_snmp && ct->status & IPS_NAT_MASK)