mmc: mtk-sd: don't hard-code interrupt trigger type
authorNeilBrown <neil@brown.name>
Sat, 4 May 2019 10:24:56 +0000 (20:24 +1000)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 6 May 2019 10:33:03 +0000 (12:33 +0200)
When using devicetree for configuration, interrupt trigger type
should be described in the dts file, not hard-coded in the C code.

The mtk-sd silicon in the mt7621 soc uses an active-high interrupt
and so cannot be used with the current code.

So replace IRQF_TRIGGER_LOW with IRQF_TRIGGER_NONE.

Also IRQF_ONESHOT is not needed - it is used for threaded interrupt
handlers, and this driver does not used a threaded interrupt handler.
So remove that setting.

Signed-off-by: NeilBrown <neil@brown.name>
Reviewed-by: Chaotian Jing <chaotian.jing@mediatek.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c

index 0798f0b..469d4a7 100644 (file)
@@ -2240,7 +2240,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
        msdc_init_hw(host);
 
        ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq,
-               IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host);
+                              IRQF_TRIGGER_NONE, pdev->name, host);
        if (ret)
                goto release;