Move rpmte-specific problem creation to a helper function

diff --git a/lib/rpmte.c b/lib/rpmte.c
index 9764c7c..2fcb5b1 100644 (file)
--- a/lib/rpmte.c
+++ b/lib/rpmte.c
@@ -197,12 +197,8 @@ static void buildRelocs(rpmte p, Header h, rpmRelocation *relocs)
            }
 
            if (!valid) {
-               if (p->probs == NULL) {
-                   p->probs = rpmpsCreate();
-               }
-               rpmpsAppend(p->probs, RPMPROB_BADRELOCATE,
-                       rpmteNEVRA(p), rpmteKey(p),
-                       p->relocs[i].oldPath, NULL, NULL, 0);
+               rpmteAddProblem(p, RPMPROB_BADRELOCATE,
+                               p->relocs[i].oldPath, NULL, NULL, 0);
            }
        } else {
            p->relocs[i].newPath = NULL;
@@ -722,6 +718,18 @@ rpmps rpmteProblems(rpmte te)
     return te ? te->probs : NULL;
 }
 
+void rpmteAddProblem(rpmte te, rpmProblemType type,
+                    const char *dn, const char *bn,
+                    const char *altNEVR, uint64_t number)
+{
+    if (te != NULL) {
+       if (te->probs == NULL)
+           te->probs = rpmpsCreate();
+       rpmpsAppend(te->probs, type, rpmteNEVRA(te), rpmteKey(te),
+                   dn, bn, altNEVR, number);
+    }
+}
+
 const char * rpmteTypeString(rpmte te)
 {
     switch(rpmteType(te)) {

diff --git a/lib/rpmte_internal.h b/lib/rpmte_internal.h
index edf9a9f..3dadcdf 100644 (file)
--- a/lib/rpmte_internal.h
+++ b/lib/rpmte_internal.h
@@ -35,6 +35,11 @@ RPM_GNUC_INTERNAL
 rpmps rpmteProblems(rpmte te);
 
 RPM_GNUC_INTERNAL
+void rpmteAddProblem(rpmte te, rpmProblemType type,
+                     const char *dn, const char *bn,
+                     const char *altNEVR, uint64_t number);
+
+RPM_GNUC_INTERNAL
 const char * rpmteTypeString(rpmte te);
 
 RPM_GNUC_INTERNAL